7x: Typescript update #6091

mjfwebb · 2025-03-14T16:35:50Z

Description

Updates the old version of @tsconfig/16 with an updated @tsconfig/22 (matching the engines in package.json of "node": ">=22.0.0")
Updates tsconfig to retain the previous production build configuration which was essentially:

        "module": "CommonJS",
        "target": "es2021",
        "moduleResolution": "node10"

Updates Typescript to 5.8.2
Addresses new errors raised during this update. Please see individual commits for errors raised.

Complexity

Low

changeset-bot · 2025-03-14T16:35:55Z

⚠️ No Changeset found

Latest commit: 613798d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This fixes the error: Cannot find module '@graphql-tools/utils/typings/types' or its corresponding type declarations.

This fixes: Property 'description' will overwrite the base property in 'GraphElement'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.

This fixes: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'.

This fixes: Property 'name' will overwrite the base property in 'Neo4jGraphQLError'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.

packages/graphql/src/schema-model/parser/parse-arguments.ts

packages/graphql/src/tsconfig.production.json

Co-authored-by: Darrell Warde <[email protected]>

mjfwebb requested review from angrykoala and darrellwarde March 14, 2025 16:35

mjfwebb changed the base branch from dev to 7.x March 14, 2025 16:36

mjfwebb added 11 commits March 21, 2025 13:48

build: update typescript to 5.8.2

06aadd1

build: update tsconfig to @tsconfig/node22

0472c8b

fix: update import path for @graphql-tools/utils

d881499

This fixes the error: Cannot find module '@graphql-tools/utils/typings/types' or its corresponding type declarations.

fix: remove redundant description property

bee5f8e

This fixes: Property 'description' will overwrite the base property in 'GraphElement'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.

fix: add explicit file extension to dynamic import

bb49425

This fixes: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'.

fix: remove unnecessary name properties

ad46804

This fixes: Property 'name' will overwrite the base property in 'Neo4jGraphQLError'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.

fix: ensure Jest strips .js extension for dynamic import resolution

ee320ad

fix: make the mapper more specific so as not to affect node modules

c3f6e42

fix: update webpack plugin to replace dynamic Subgraph import extension

2be73d6

fix: use node10 moduleResolution, es2021 target and CommonJS module

819ded8

fix: remove unused NormalModuleReplacementPlugin

9063bac

mjfwebb force-pushed the mjfwebb/7x-ts-update branch from 42e0b6c to 9063bac Compare March 21, 2025 12:48

darrellwarde previously approved these changes Mar 21, 2025

View reviewed changes

packages/graphql/src/schema-model/parser/parse-arguments.ts Outdated Show resolved Hide resolved

packages/graphql/src/tsconfig.production.json Outdated Show resolved Hide resolved

Update packages/graphql/src/schema-model/parser/parse-arguments.ts

add5eec

Co-authored-by: Darrell Warde <[email protected]>

mjfwebb dismissed darrellwarde’s stale review via add5eec March 21, 2025 13:31

Update packages/graphql/src/tsconfig.production.json

613798d

Co-authored-by: Darrell Warde <[email protected]>

mjfwebb merged commit 04a2f8c into neo4j:7.x Mar 21, 2025
35 checks passed

mjfwebb mentioned this pull request Mar 21, 2025

7.x: Add changeset for Typescript update #6099

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7x: Typescript update #6091

7x: Typescript update #6091

mjfwebb commented Mar 14, 2025 •

edited

Loading

changeset-bot bot commented Mar 14, 2025 •

edited

Loading

7x: Typescript update #6091

7x: Typescript update #6091

Conversation

mjfwebb commented Mar 14, 2025 • edited Loading

Description

Complexity

changeset-bot bot commented Mar 14, 2025 • edited Loading

⚠️ No Changeset found

mjfwebb commented Mar 14, 2025 •

edited

Loading

changeset-bot bot commented Mar 14, 2025 •

edited

Loading