Adds completion for YIELD elements in a procedure call #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: feba9a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ncordon
reviewed
Nov 15, 2024
| }); | ||
|
|
||
| test('Correctly completes YIELD when we have backticks in the procedure name', () => { | ||
| const query1 = 'CALL `dbms`.`components`() YIELD '; |
There was a problem hiding this comment.
I'd like to see a test that works for:
CALL dbms.components() YIELD n // offers name as completion
CALL dbms.components() YIELD name, e // offers edition as completion
CALL dbms.components() YIELD name, edition, // offers version as completion
I think that was not working yesterday and it should
There was a problem hiding this comment.
And it would be nice if we can fix these completions:
CALL dbms.components() YIELD name, version RETURN ^
and get name, version as possible completions there
ncordon
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a procedure call like:
we want to get completions for the different return elements the procedure can produce.
This PR adds that.