WIP: Lstsq solver #150
Open
WIP: Lstsq solver #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for custom building of solvers. It also builds the activities matrix using the device if possible.
TODO: Cannot do cholesky solve in tests.test_builder.test_LstsqL2_solver because matrix too near singular. Why? Also, the error as the code currently is is too big. Something weird is going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently not working well. As seen in the test included in the commit, it makes performance a lot worse as compared to the nengo version for the large near-singular system. Also, cho_solve doesn't work because it's so near-singular, but I'm using cho_solve in nengo so something else is weird with how the matrices are being computed on the GPU.