Update action internals and bump major #1
Conversation
|
@dcoraboeuf when you have a chance this updates the action to use newer deps etc. |
|
There seems to be an issue with the build, I'll check tomorrow morning my time since I am on my mobile phone and this is not so practical to check things... Thanks already for your contribution! |
Ontrack cli setup step has an issue here https://github.com/nemerosa/ontrack-github-actions-cli-validation/pull/1/checks#step:4:9 and as a result does not output a branch to use in subsequent steps. There may be other issues but I would start there. |
|
I've fixed the support for PRs in the Can you rebase or merge your PR head branch from the |
rathpc
force-pushed
the
rathpc/update-deps
branch
from
f48f2ed to
fd60f9f
Compare
Updated just now |
|
@dcoraboeuf just bumping this up. I also left a comment on the other action PR regarding versions in case you had missed it. |
|
Version issue is now fixed. |
|
The build now fails with:
Having a look. |
|
After some back and forths, it all comes down to the fact that secrets are not passed for PR coming for forks: https://docs.github.com/en/actions/security-guides/encrypted-secrets#using-encrypted-secrets-in-a-workflow
I therefore need to disable all the |
This includes: - Updating dependencies to latest - Update package-lock.json to latest version - Resolve lint issues as a result of updating deps - Update action to run using node16 - Bump version to 2.0.0
rathpc
force-pushed
the
rathpc/update-deps
branch
from
fd60f9f to
f0166c4
Compare
|
Hey @dcoraboeuf I am bringing this back to life with a small change that skips the ontrack-cli steps if running on a fork |
|
@dcoraboeuf Happy new year! just giving this a bump to make sure it doesn't get lost, thanks! |
|
Happy new year to you as well @rathpc ! I'm having a look at it right now, sorry for the big delays :( |
|
@dcoraboeuf thank you! Can you trigger a release so that new tags are available? I know you had an issue doing this the first time for the other action so I just wanted to call that out in case there is something you have to change for this one to fix that here as well. |
|
Done. Moved v1, created v1.1 and v1.10. I seriously need to revisit the release process of these actions! |
It should be v2, v2.0 and v2.0.0, not v1 to align with the tags in https://github.com/nemerosa/ontrack-github-actions-cli-setup |
|
Done as well :)
…On Tue, Jan 16, 2024 at 10:27 PM Steven Rathbauer ***@***.***> wrote:
Done. Moved v1, created v1.1 and v1.10.
I seriously need to revisit the release process of these actions!
It should be v2, v2.0 and v2.0.0, not v1 to align with the tags in
https://github.com/nemerosa/ontrack-github-actions-cli-setup
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJGVNBLUBPEQ7ETJHJ3DE3YO3WDJAVCNFSM6AAAAAA32JTBXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGUZTQOBSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
This includes: