-
-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(symfony): describe MapUploadedFile property #2418
feat(symfony): describe MapUploadedFile property #2418
Conversation
5cc5688
to
9f80b3c
Compare
Had to update my branch a few times to get rid of a merge requirement - didn't expect |
9f80b3c
to
f41a273
Compare
Do we need to update the major version in NelmioApiDocBundle/.doctor-rst.yaml Line 56 in 8e56941
|
f41a273
to
45f5e86
Compare
PHPStan fails as Symfony packages are locked to 7.0 by
When / how do we change this? |
Fixed in #2419 |
Yeah bumping that version and removing the old referenced to 6.x in the docs will fix it |
45f5e86
to
fab548d
Compare
I just rebased my branch on current master to make checks to include your changes from #2419. As I do not fully understand the ReStructured docs |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2418 +/- ##
==========================================
+ Coverage 90.18% 90.24% +0.05%
==========================================
Files 94 95 +1
Lines 3067 3085 +18
==========================================
+ Hits 2766 2784 +18
Misses 301 301 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@jankal I do not have permission to edit your PR :) |
A merge/rebase with master should fix it |
fab548d
to
d53b024
Compare
@DjordyKoert thx! So you just removed the references to That's what I didn't want to do because the info would be lost after my PR was merged and docs updated. Can you explain how users of the library will be able to figure out this info in the future? - I'm just curious :) I did the rebase. This should be ready to merge then. |
(The doctor seems to still have eissues... now bc of your change to require |
d53b024
to
98f4627
Compare
Thank you ❤️ |
Description
Added support for the
#[MapUploadedFile]
Symfony controller argument attribute.What type of PR is this? (check all applicable)
Checklist
docs/
)CHANGELOG.md
)