Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(symfony): describe MapUploadedFile property #2418

Merged

Conversation

jankal
Copy link
Contributor

@jankal jankal commented Jan 7, 2025

Description

Added support for the #[MapUploadedFile] Symfony controller argument attribute.

What type of PR is this? (check all applicable)

  • Bug Fix
  • Feature
  • Refactor
  • Deprecation
  • Breaking Change
  • Documentation Update
  • CI

Checklist

  • I have made corresponding changes to the documentation (docs/)
  • I have made corresponding changes to the changelog (CHANGELOG.md)

@jankal jankal force-pushed the feature/map-uploaded-file branch 3 times, most recently from 5cc5688 to 9f80b3c Compare January 7, 2025 22:51
@jankal
Copy link
Contributor Author

jankal commented Jan 7, 2025

Had to update my branch a few times to get rid of a merge requirement - didn't expect master to have moved forward in between already.

@jankal jankal force-pushed the feature/map-uploaded-file branch from 9f80b3c to f41a273 Compare January 7, 2025 22:56
@jankal
Copy link
Contributor Author

jankal commented Jan 7, 2025

Do we need to update the major version in

major_version: 6
to make the docs linter pass?

@jankal jankal force-pushed the feature/map-uploaded-file branch from f41a273 to 45f5e86 Compare January 7, 2025 23:01
@jankal
Copy link
Contributor Author

jankal commented Jan 8, 2025

PHPStan fails as Symfony packages are locked to 7.0 by

When / how do we change this?

@DjordyKoert
Copy link
Collaborator

PHPStan fails as Symfony packages are locked to 7.0 by

When / how do we change this?

Fixed in #2419

@DjordyKoert
Copy link
Collaborator

Do we need to update the major version in

major_version: 6

to make the docs linter pass?

Yeah bumping that version and removing the old referenced to 6.x in the docs will fix it

@jankal jankal force-pushed the feature/map-uploaded-file branch from 45f5e86 to fab548d Compare January 8, 2025 12:18
@jankal
Copy link
Contributor Author

jankal commented Jan 8, 2025

I just rebased my branch on current master to make checks to include your changes from #2419.

As I do not fully understand the ReStructured docs versionadded tags, I will leave this upgrade from 6 to 7 to you @DjordyKoert

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (8b4803f) to head (98f4627).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2418      +/-   ##
==========================================
+ Coverage   90.18%   90.24%   +0.05%     
==========================================
  Files          94       95       +1     
  Lines        3067     3085      +18     
==========================================
+ Hits         2766     2784      +18     
  Misses        301      301              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DjordyKoert
Copy link
Collaborator

I just rebased my branch on current master to make checks to include your changes from #2419.

As I do not fully understand the ReStructured docs versionadded tags, I will leave this upgrade from 6 to 7 to you @DjordyKoert

@jankal I do not have permission to edit your PR :)

@DjordyKoert
Copy link
Collaborator

I just rebased my branch on current master to make checks to include your changes from #2419.
As I do not fully understand the ReStructured docs versionadded tags, I will leave this upgrade from 6 to 7 to you @DjordyKoert

@jankal I do not have permission to edit your PR :)

A merge/rebase with master should fix it

@jankal jankal force-pushed the feature/map-uploaded-file branch from fab548d to d53b024 Compare January 26, 2025 09:37
@jankal
Copy link
Contributor Author

jankal commented Jan 26, 2025

@DjordyKoert thx! So you just removed the references to 6.* from the docs?

That's what I didn't want to do because the info would be lost after my PR was merged and docs updated. Can you explain how users of the library will be able to figure out this info in the future? - I'm just curious :)

I did the rebase. This should be ready to merge then.

@jankal
Copy link
Contributor Author

jankal commented Jan 26, 2025

(The doctor seems to still have eissues... now bc of your change to require 4.*)

@jankal jankal force-pushed the feature/map-uploaded-file branch from d53b024 to 98f4627 Compare January 27, 2025 09:31
@DjordyKoert DjordyKoert merged commit e373f62 into nelmio:master Mar 7, 2025
25 checks passed
@DjordyKoert
Copy link
Collaborator

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants