Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable "unable to get git repo" when none exists. #2495

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disable "unable to get git repo" when none exists. #2495

wants to merge 2 commits into from
+4 −1

Conversation

stephenwithav
Copy link

Closes #2493.

@stephenwithav stephenwithav requested a review from a team as a code owner October 19, 2024 23:23
ChristopherHX
ChristopherHX reviewed Oct 20, 2024
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overal agree about silencing this warning, in my use of act this code is effectively disabled.

Neutral, I approve if another maintainer approves

pkg/model/github_context.go Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Oct 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.98%. Comparing base (5a80a04) to head (006b08b).
Report is 121 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2495       +/-   ##
===========================================
+ Coverage   61.56%   74.98%   +13.42%     
===========================================
  Files          53       62        +9     
  Lines        9002    10011     +1009     
===========================================
+ Hits         5542     7507     +1965     
+ Misses       3020     1940     -1080     
- Partials      440      564      +124

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot requested a review from a team October 20, 2024 09:50
ChristopherHX
ChristopherHX approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

act shouldn't complain when there's no remote repo
2 participants
@stephenwithav @ChristopherHX