-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unit type mappings #6
base: master
Are you sure you want to change the base?
Conversation
Code looks good, but not sure it is all done yet: I’m running this branch on a client’s db1 like so:
And things look promising in the console:
But all metrics show up as “Metrics with no dimensions” Graphing e.g. various My expectation would be that this shows up as milliseconds, and that other metrics are received with their respective units as well. |
That's very curious. On my dashboard, request_time values do show up as milliseconds 🤔 |
@garbados can you give it a spin in the customer environment? |
Sure thing, I'll try that. |
I don't have access to the AWS console for these instances, so while I can run the tool from the client environment, I'm unable to examine the resultant metrics in AWS currently. |
I've improved the type mappings and tested it from the Ruum box; everything seems to look right. Let me know what looks amiss and I'll fix it. |
WIP branch for adding unit type mappings to the collected metrics. This PR checks metric keys for known suffixes like 'uptime' or 'cluster' which it maps to particular type values, like 'ms' or 'counter' respectively.
I tried to be thorough but I recognize there are mappings I may have missed or misinterpreted.