Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unit type mappings #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: unit type mappings #6

wants to merge 3 commits into from

Conversation

garbados
Copy link
Contributor

WIP branch for adding unit type mappings to the collected metrics. This PR checks metric keys for known suffixes like 'uptime' or 'cluster' which it maps to particular type values, like 'ms' or 'counter' respectively.

I tried to be thorough but I recognize there are mappings I may have missed or misinterpreted.

@garbados garbados self-assigned this Mar 20, 2018
@garbados garbados added the enhancement New feature or request label Mar 20, 2018
@garbados garbados requested review from janl and wohali March 20, 2018 18:59
@janl
Copy link
Contributor

janl commented Mar 22, 2018

Code looks good, but not sure it is all done yet:

I’m running this branch on a client’s db1 like so:

 DEBUG=1 AWS_REGION=$REGION COUCH_URL=$COUCHDB_URL ./bin.js start -i 60000

And things look promising in the console:

[aws-couchwatch] Setting up...
[aws-couchwatch] Set up to handle 2.x instance.
1244 metrics received.
1236 metrics received.
1257 metrics received.
1243 metrics received.
1250 metrics received.
1248 metrics received.

But all metrics show up as “Metrics with no dimensions”

screen shot 2018-03-22 at 13 10 43

Graphing e.g. various request_time metrics produce reasonable graphs, but with non-sensible units:

screen shot 2018-03-22 at 13 12 33

My expectation would be that this shows up as milliseconds, and that other metrics are received with their respective units as well.

@garbados
Copy link
Contributor Author

That's very curious. On my dashboard, request_time values do show up as milliseconds 🤔

@janl
Copy link
Contributor

janl commented Mar 28, 2018

@garbados can you give it a spin in the customer environment?

@garbados
Copy link
Contributor Author

Sure thing, I'll try that.

@garbados
Copy link
Contributor Author

garbados commented Mar 28, 2018

I don't have access to the AWS console for these instances, so while I can run the tool from the client environment, I'm unable to examine the resultant metrics in AWS currently.

@garbados
Copy link
Contributor Author

garbados commented May 3, 2018

I've improved the type mappings and tested it from the Ruum box; everything seems to look right. Let me know what looks amiss and I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants