Skip to content

Commit

Permalink
KOJO-167,169,175 | Clarify the process pool server start command exit…
Browse files Browse the repository at this point in the history
… code
  • Loading branch information
mucha55 committed Jan 7, 2020
1 parent 0db8cfc commit 5a5c1c3
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/Console/Command/Process/Pool/Server/Start.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,9 @@ public function _execute(): int
$arguments[] = self::OPT_YSDP . $servicesYmlFilePath;
}
pcntl_exec(__DIR__ . '/../../../../../../bin/kojo', $arguments);
$this->_getOutput()->writeln('An error occurred trying to start the process pool server.');

// currently there is no graceful shutdown flow for kojo, it works until terminated
// if, in the future, we want such a flow, and want to expose its success via exit code, we will need to make changes here
// this code will only get executed if the pcntl_exec() fails, so exit with a non-zero code
$this->_getOutput()->writeln('An error occurred trying to start the process pool server.');
return 255;
}

Expand Down

0 comments on commit 5a5c1c3

Please sign in to comment.