Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/zookeeper version #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feat/zookeeper version #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e32266d
fix(readline): should be a default after php7.3
Dec 20, 2021
4636ce1
feat(zookeeper): made it default arg to use verion v1.0.0
Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions php-8.0/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
FROM php:8.0-fpm AS php-8.0-base

# v1.0.0 is the first version to offically support php8.0
ARG ZOOKEEPER_EXT_VERSION="v1.0.0"

# Install base libs
RUN apt-get update && \
apt-get install -y --no-install-recommends \
Expand Down Expand Up @@ -39,7 +42,6 @@ RUN docker-php-ext-install \
bcmath \
mbstring \
pcntl \
readline \
posix \
sysvmsg \
sysvsem \
Expand Down Expand Up @@ -70,9 +72,7 @@ RUN docker-php-ext-configure imap --with-imap-ssl --with-kerberos && \
docker-php-ext-install imap

## Install Zookeeper
## FIXME: Making this way too dynamic php8.0 not yet supported in a release but is supported on master
## Probably want to go to v0.6.4 as soon as its released
RUN curl -L -o /tmp/zookeeper.tar.gz https://github.com/php-zookeeper/php-zookeeper/archive/refs/heads/master.tar.gz \
RUN curl -L -o /tmp/zookeeper.tar.gz "https://github.com/php-zookeeper/php-zookeeper/archive/refs/tags/${ZOOKEEPER_EXT_VERSION}.tar.gz" \
&& mkdir -p /tmp/zookeeper \
&& tar xfz /tmp/zookeeper.tar.gz -C /tmp/zookeeper --strip-components=1 \
&& rm -r /tmp/zookeeper.tar.gz \
Expand Down