Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members expansion #217

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Members expansion #217

merged 8 commits into from
Apr 4, 2024

Conversation

radu-constantin
Copy link
Collaborator

Created a dropdown list of neighborhood members.
Added app favicon and changed app title to 'Neighborhood'

@radu-constantin radu-constantin added the frontend Issues related to the frontend label Mar 17, 2024
@radu-constantin radu-constantin requested a review from nina-dk March 17, 2024 07:04
@radu-constantin radu-constantin linked an issue Mar 17, 2024 that may be closed by this pull request
@nina-dk
Copy link
Collaborator

nina-dk commented Mar 17, 2024

@radu-constantin Hey, great job! 🙌🏻 I really like how the first few circles can be selected individually, otherwise the dropdown opens.

If and when the user icons are implemented, I'd love to show them in the form of a 3x3 or 4x4 list of icons instead of a list with the usernames and circles, but that can wait.

I'd also like to display the admin somewhat separately but I'm not sure it's worth the hustle at this point.

One concerning thing I noticed is that the user info passed to the component includes the user password hashes. Could you look into that?

I'm also not seeing the favicon in my browser tab. I don't think it's rendered from the backend as far as I can tell.

@radu-constantin
Copy link
Collaborator Author

Fixed the password-hash issue for users and admin.

Copy link
Collaborator

@nina-dk nina-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-04-02 at 11 43 32 AM

I'm getting a bug where I can't scroll down on the single neighborhood page, even though there is obviously more info. Do you get that too?

Otherwise, looks great!

Copy link

render bot commented Apr 4, 2024

@radu-constantin radu-constantin merged commit 273195b into main Apr 4, 2024
2 checks passed
@radu-constantin radu-constantin deleted the members-expansion branch May 4, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues related to the frontend
Projects
None yet
2 participants