-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Members expansion #217
Members expansion #217
Conversation
@radu-constantin Hey, great job! 🙌🏻 I really like how the first few circles can be selected individually, otherwise the dropdown opens. If and when the user icons are implemented, I'd love to show them in the form of a 3x3 or 4x4 list of icons instead of a list with the usernames and circles, but that can wait. I'd also like to display the admin somewhat separately but I'm not sure it's worth the hustle at this point. One concerning thing I noticed is that the user info passed to the component includes the user password hashes. Could you look into that? I'm also not seeing the favicon in my browser tab. I don't think it's rendered from the backend as far as I can tell. |
Fixed the password-hash issue for users and admin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your Render PR Server URL is https://neighborhood-backend-pr-217.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-co71vcf109ks73e5q9og. |
Created a dropdown list of neighborhood members.
Added app favicon and changed app title to 'Neighborhood'