[fix] z-index causes images to not show in iOS 18.3 sometimes #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ad6b624:
|
ayroblu
force-pushed
the
z-index-image
branch
from
1ad74d2 to
ad6b624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @necolas,
I noticed after I updated my phone to iOS 18.3 that some avatar images stopped loading for me in the account switcher in x.com, most likely a webkit issue. A fix appears to be removing this z-index, though I'm not sure about the exact set of circumstances to trigger this, though it's deterministic for mobile account switcher. I'm also not sure why a negative z-index was added in the first place here.
Let me know if you need anything