[ENH] - Include "--attempt-fixes" flag from Nebari upgrade CLI in upgrade steps logic

[smokestacklightnin]

Reference Issues or PRs

This resloves #2761 by passing the attempt_fixes variable from the command line option to the upgrade methods.

What does this implement/fix?

Put a x in the boxes that apply

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds a feature)
• Breaking change (fix or feature that would cause existing features not to work as expected)
• Documentation Update
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Other (please describe):

Testing

• Did you test the pull request locally?
• Did you add new tests?

How to test this PR?

Run nebari upgrade --attempt-fixes and verify that the upgrade is successful without prompts from the user.

Any other comments?

[smokestacklightnin]

Is there a way to automate the deletion of Argo Workflow CRDs? Otherwise, we are just assuming that the deletion already took place if attempt_fixes == true.

The same type of question applies to more changes below in the upgrade.py.

[dcmcand]

Yes, there is. @marcelovilla did it for the Prometheus operator upgrade. See

nebari/src/_nebari/upgrade.py

Line 1043 in 855aa14

if run_commands == "y":

for a reference.

[marcelovilla]

@smokestacklightnin did you see the approach I implemented? You'd need to add the logic to automatically delete the relevant CRDs here if the attempt_fixes is passed. We would need an extra step or we would need to reframe the question, though.

[dcmcand]

This should probably be a draft PR if you still have questions about the implementation

[marcelovilla]

@smokestacklightnin did you see the approach I implemented? You'd need to add the logic to automatically delete the relevant CRDs here if the attempt_fixes is passed. We would need an extra step or we would need to reframe the question, though.

[marcelovilla]

@smokestacklightnin can you also make sure the tests are passing?