Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable jupyterlab-jhub-apps extension when jhub-apps is disabled #2804

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Oct 29, 2024

Reference Issues or PRs

Reference for the labconfig/page_config.json file:

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
    Yes
  • Did you add new tests?

How to test this PR?

  1. Deploy with:
default_images:
  jupyterhub: quay.io/nebari/nebari-jupyterhub:jhub-apps-2024-10-1-and-jlab-ext
  jupyterlab: quay.io/nebari/nebari-jupyterlab:jhub-apps-2024-10-1-and-jlab-ext
jhub_apps:
  enabled: true
  1. Open JupyterLab
  2. Open a Notebook
  3. See that there is a toolbar item ":rocket: Deploy App" like this:
    image
  4. Switch jhub_apps.enabled to false and deploy again
  5. Open JupyterLab/Notebook see that the toolbar item is no longer here

Any other comments?

None

@krassowski
Copy link
Member Author

I believe the failing integration test is unrelated and tracked in #2777.

so that it applies across potential JupyterLab startup environments

also the previous spec was incorrectly pointing to a file (not a dir)
@krassowski krassowski marked this pull request as ready for review October 29, 2024 14:12
@marcelovilla marcelovilla added this to the 2024.10.1 release milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New 🚦
Development

Successfully merging this pull request may close these issues.

3 participants