Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Include Backup-Restore service components #2764

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[ENH] Include Backup-Restore service components #2764

wants to merge 6 commits into from

Conversation

viniciusdc
Copy link
Contributor

Reference Issues or PRs

closes #2657

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@viniciusdc viniciusdc linked an issue Oct 9, 2024 that may be closed by this pull request
[ENH] - Expose Backup and Restore for Keycloak API #2657
Open
dcmcand
dcmcand reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viniciusdc do we need the force_unlock stuff for this? That seems like it should be a separate PR

src/_nebari/stages/kubernetes_services/template/backup-restore.tf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a duplicate? I am confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcmcand dcmcand dcmcand left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Status: New 🚦
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] - Expose Backup and Restore for Keycloak API
2 participants
@viniciusdc @dcmcand