-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add taint to user nodes #2605
base: main
Are you sure you want to change the base?
Add taint to user nodes #2605
Changes from 8 commits
5000f06
7ce8555
a661514
fb55fab
7f1800d
40940f6
cdac5c6
6382c7b
e9d9dd9
c55cd5f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,6 +96,22 @@ resource "helm_release" "grafana-promtail" { | |
values = concat([ | ||
file("${path.module}/values_promtail.yaml"), | ||
jsonencode({ | ||
tolerations = [ | ||
{ | ||
key = "node-role.kubernetes.io/master" | ||
operator = "Exists" | ||
effect = "NoSchedule" | ||
}, | ||
{ | ||
key = "node-role.kubernetes.io/control-plane" | ||
operator = "Exists" | ||
effect = "NoSchedule" | ||
}, | ||
Comment on lines
+100
to
+109
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These top 2 are the default value for this helm chart. |
||
{ | ||
operator = "Exists" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. runs promtail on all nodes, even those with NoSchedule taints. Doesn't run on nodes with NoExecute taints. This is what the nebari-prometheus-node-exporter daemonset does so I copied it here. Promtail is what exports logs from the node so we still want it to run on the user and worker nodes. |
||
effect = "NoSchedule" | ||
}, | ||
] | ||
}) | ||
], var.grafana-promtail-overrides) | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,13 @@ resource "helm_release" "rook-ceph" { | |
}, | ||
csi = { | ||
enableRbdDriver = false, # necessary to provision block storage, but saves some cpu and memory if not needed | ||
provisionerReplicas : 1, # default is 2 on different nodes | ||
pluginTolerations = [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. runs csi-driver on all nodes, even those with NoSchedule taints. Doesn't run on nodes with NoExecute taints. This is what the nebari-prometheus-node-exporter daemonset does so I copied it here. |
||
{ | ||
operator = "Exists" | ||
effect = "NoSchedule" | ||
} | ||
], | ||
}, | ||
}) | ||
], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate class