Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add AWS IAM permissions_boundary option #2078 #2082

Merged
merged 10 commits into from
Oct 26, 2023

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Oct 20, 2023

Reference Issues or PRs

close #2078

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@fangchenli fangchenli marked this pull request as ready for review October 22, 2023 04:40
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fangchenli! This looks good to me but have you had a chance to test this on AWS yet?

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on AWS and this LGTM. Thanks @fangchenli!

@iameskild iameskild merged commit 7459abe into nebari-dev:develop Oct 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] - Allow AWS deployments to specify IAM permission boundaries
2 participants