ci: enable artifact signing (grant id-token/attestations to reusable-workflow callers)#144
Draft
dcmcand wants to merge 1 commit into
Draft
ci: enable artifact signing (grant id-token/attestations to reusable-workflow callers)#144dcmcand wants to merge 1 commit into
dcmcand wants to merge 1 commit into
Conversation
Grants id-token + attestations at the caller jobs so the reusable workflows can keyless-sign + attest this pack's images and chart once the signing-enabled reusable workflows ship under @v1. Permissions only; inert until then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Grants the
id-token+attestationspermissions the reusablepack-build-image/pack-releaseworkflows need so this pack's containerimages and Helm chart get keyless-signed + attested (provenance + SBOM) once the
signing-enabled reusable workflows ship under
@v1.Permissions only - no
uses:ref change (stays@v1), no chart version bump, noother behavior change.
Why it's blocked
@v1does not include signing yet; that's nebari-dev/.github#46. Until #46merges and
v1is retagged, these permission grants are inert (unused, harmless).Merge order: #46 →
v1retag → this PR.Validated
The full signing path (these exact caller permissions + the reusable workflows)
was already exercised end-to-end against this pack from a throwaway test branch:
all 4 images signed on both ghcr and quay, the chart
.tgzsigned, everythingcosign verify-ed successfully. See the validation comment onnebari-dev/.github#46. The canonical OCI chart signing is nebari-dev/helm-repository#64.