fix: update vite config in production to correctly serve static files #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
![review-bot-for-github[bot]](https://avatars.githubusercontent.com/u/1544687?s=60&v=4){kind=small}
✅ Deploy Preview for quantum-deploy-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ergusto
force-pushed
the
feat/vite-config-base-path-for-gh-pages
branch
from
5f5c5ae to
4310402
Compare
simoneb
reviewed
Apr 15, 2024
ergusto
force-pushed
the
feat/vite-config-base-path-for-gh-pages
branch
3 times, most recently
from
145c181 to
4310402
Compare
|
@simoneb CI runs correctly now, the issue should now be fixed but unfortunately I won't know 100% until it's been deployed to Gtihub Pages. I tried deploying against this branch just to check but there are (rightly) protections to prevent this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static files in Storybook were pointing at 'https://nearform.github.io` instead of
https://nearform.github.io/quantum.