chore: fake timer #528
Merged
chore: fake timer #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ilteoood
commented
Dec 14, 2024
•
ilteoood
commented
- Remove sinon fake timer in favour of node tests one
|
No linked issues found. Please add the corresponding issues in the pull request description. |
simoneb
reviewed
Dec 15, 2024
package.json
Outdated
| @@ -58,7 +58,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@node-rs/jsonwebtoken": "^0.5.9", | |||
| "@sinonjs/fake-timers": "^13.0.5", | |||
| "@sinonjs/fake-timers": "^14.0.0", | |||
There was a problem hiding this comment.
any chance we can use Node's built in mock timers?
There was a problem hiding this comment.
The last time I tried it was not working well on node 20, let me try that again
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- package.json: Language not supported
ilteoood
force-pushed
the
chore/fake-timer
branch
from
34baa38 to
87c8fe1
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
test/verifier.spec.js:1098
- The word 'directy' should be 'directly'.
test('caching - should be able to manipulate cache directy', t => {
simoneb
reviewed
Dec 16, 2024
simoneb
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.