Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix react sample startup guide & add needful dependency … #1128

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,14 @@ Build and deploy angular example
yarn nx build angular # build the angular example
yarn nx deploy angular # deploys angular example to gh-pages
```
# Submitting a PR
The initial comment has instructions. For your PR to be considered, you must select a template, include details, and make the appropriate selections from the checkboxes provided.

1. Select the preview tab.
2. Select the applicable template. This replaces the comment with the correct placeholder text.

![Submit PR Step 1](https://github.com/near/wallet-selector/blob/main/images/submit_PR_step_1.png)
![Submit PR Step 2](https://github.com/near/wallet-selector/blob/main/images/submit_PR_step_2.png)

# Branching

Expand Down
9 changes: 9 additions & 0 deletions examples/react/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,16 @@
This React example shows how to integrate Near Wallet Selector into your React application for easy Near wallet integration.

# Usage
Make sure your node version is 18

Then perform the build:
```bash
yarn build:all
```
Need to add a separate dependency, otherwise a error `Module not found` will be reported.
```bash
yarn add @near-wallet-selector/modal-ui
```
Start the development server:
```bash
yarn nx serve react
Expand Down
Binary file added images/submit_PR_step_1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/submit_PR_step_2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading