Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new wallet (arepa wallet) #1121

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

add new wallet (arepa wallet) #1121

wants to merge 1 commit into from

Conversation

hrpalencia
Copy link

@hrpalencia hrpalencia commented Jun 20, 2024

Description

https://arepita.gitbook.io/miarepa-wallet

Please provide more details - TB. Please make selections below - TB.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@trechriron trechriron requested a review from hcho112 July 3, 2024 18:29
Copy link
Contributor

@hcho112 hcho112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things.

  1. Please rebase the latest dev branch of wallet-selector
  2. I tried to test them by running it locally but wail to do so. I'm encountering this error
image

I was able to run latest dev branch of original repo

@trechriron
Copy link
Collaborator

hrpalencia—Please add details and make selections in your initial comment. I copied the template back in. In the future, please follow the instructions in the first comment. You change to the preview tab and select a template, which populates your comment field. With these checkboxes, your PR will pass tests. Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: NEW❗
Development

Successfully merging this pull request may close these issues.

None yet

3 participants