Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update near-api-js Dependency #1105

Closed
wants to merge 5 commits into from

Conversation

bh2smith
Copy link

@bh2smith bh2smith commented May 27, 2024

Description

This change updates the near-api-js dependency on the global level of this package to v3 (I thought incremental steps would make the changes easier to introduce). Note that only a few tests had to be adjusted (but the changes were trivial). One in wallet-utils and one in leger-client. Furthermore, we update the "peerDependencies" in all the packages (really not sure why these are even here).

If approved, this closes #1104.

To make review easier, the most relevant diff is in this commit: 962839e

If accepted, I would proceed in continuing on to upgrade to v4.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

CHORE - Update long outdated package (cf #1104)

Note that I have not yet managed to build the entire project locally. These are the build status results:

✔    21/24 succeeded [1 read from cache]

✖    3/24 targets failed, including the following:
     - nx run near-mobile-wallet:build
     - nx run account-export:build
     - nx run modal-ui:build

I am trying to track down the culprits:

  1. Near Mobile Wallet has this open PR that is passing
  2. The other common problem appears to be with a few react Elements not having "children":
Argument of type 'Element' is not assignable to parameter of type 'ReactNode'.
  Property 'children' is missing in type 'Element' but required in type 'ReactPortal'.

@@ -2,8 +2,7 @@
"eslint.format.enable": true,
"prettier.enable": false,
"editor.codeActionsOnSave": {
"source.fixAll.eslint":
true
"source.fixAll.eslint": "explicit"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file format of this settings file was invalid.

@gtsonevv
Copy link
Collaborator

@trechriron This PR can be closed. NAJ will be updated to v4 in 1135

@bh2smith bh2smith closed this Jul 18, 2024
@bh2smith bh2smith deleted the core/update-peer-dep branch July 18, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

Update near-api-js dependency
2 participants