Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc, Q1'25-CQH] synthetic benchmarks documentation updates #12814

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ssavenko-near
Copy link
Contributor

Clarifies usage and some gotchas I encountered while getting acquainted with the tool.

Clarifies usage and some gotchas I encountered while getting acquainted with the tool.
@ssavenko-near ssavenko-near requested a review from mooori January 28, 2025 08:48
@ssavenko-near ssavenko-near marked this pull request as ready for review January 28, 2025 08:48
@ssavenko-near ssavenko-near requested a review from a team as a code owner January 28, 2025 08:48
@@ -38,6 +38,18 @@ Before an RPC request is sent, the tooling awaits capacity on a buffered channel

The tooling's [`justfile`](../../../benchmarks/synth-bm/justfile) contains recipes for the most relevant workflows.

A typical workflow benchmarking the native token transfers using the above `justfile` would be something along the:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is specific to the native transfer benchmark, it might go into the subsection ### Benchmark native token transfers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it to the ### Benchmark native token transfers subsection and reshuffled things around to keep these reasonably close to the top of the file. PTAL

Copy link
Contributor

@mooori mooori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the spellcheck warnings, can be done with something like this.

@mooori
Copy link
Contributor

mooori commented Jan 28, 2025

For markdown the cspell syntax is:

<!-- cspell:words DVFS -->

@ssavenko-near
Copy link
Contributor Author

I'm for going with #12817 and removing these two sentences here, because I had some issues too with the justfile picking up /target/release/neard.

Makes sense. Removed.

@ssavenko-near
Copy link
Contributor Author

Please fix the spellcheck warnings, can be done with something like this.

Done.

@ssavenko-near ssavenko-near requested a review from mooori January 28, 2025 14:53
@mooori
Copy link
Contributor

mooori commented Jan 28, 2025

Looks like the section on enabling memtrie was removed. Usually we want to enable memtrie for all benchmark runs, even when using the default config. So mentioning it only in the "Un-limiting config" section is not sufficient. Please add back "Enable memtrie", then it should be good to go.

@ssavenko-near
Copy link
Contributor Author

Looks like the section on enabling memtrie was removed. Usually we want to enable memtrie for all benchmark runs, even when using the default config. So mentioning it only in the "Un-limiting config" section is not sufficient. Please add back "Enable memtrie", then it should be good to go.

Done!

Copy link
Contributor

@mooori mooori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@mooori mooori requested a review from akhi3030 January 28, 2025 15:41
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.44%. Comparing base (57b9b81) to head (a00496f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12814      +/-   ##
==========================================
+ Coverage   70.41%   70.44%   +0.02%     
==========================================
  Files         848      848              
  Lines      174849   174849              
  Branches   174849   174849              
==========================================
+ Hits       123117   123166      +49     
+ Misses      46485    46428      -57     
- Partials     5247     5255       +8     
Flag Coverage Δ
backward-compatibility 0.16% <ø> (ø)
db-migration 0.16% <ø> (?)
genesis-check 1.41% <ø> (ø)
linux 70.05% <ø> (-0.03%) ⬇️
linux-nightly 70.08% <ø> (+<0.01%) ⬆️
pytests 1.71% <ø> (+0.29%) ⬆️
sanity-checks 1.52% <ø> (?)
unittests 70.27% <ø> (-0.02%) ⬇️
upgradability 0.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants