Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relaxed_chunk_validation: stabilize #12736

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

nagisa
Copy link
Collaborator

@nagisa nagisa commented Jan 14, 2025

cc @VanBarbascu this is the last commit in series for new_transactions removal.

cc #12695

@nagisa nagisa requested review from pugachAG and jancionear January 14, 2025 14:23
@nagisa nagisa requested a review from a team as a code owner January 14, 2025 14:23
@nagisa nagisa force-pushed the stabilize-relaxed-chunk-validation branch 3 times, most recently from e5ac8f3 to 2a960a9 Compare January 23, 2025 12:58
@nagisa nagisa force-pushed the stabilize-relaxed-chunk-validation branch from 2a960a9 to 7114d0a Compare January 23, 2025 13:13
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 70.27027% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70.51%. Comparing base (058ef4d) to head (7114d0a).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...chain/src/stateless_validation/chunk_validation.rs 68.51% 16 Missing and 1 partial ⚠️
...src/stateless_validation/state_witness_producer.rs 58.33% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12736   +/-   ##
=======================================
  Coverage   70.51%   70.51%           
=======================================
  Files         846      846           
  Lines      174633   174610   -23     
  Branches   174633   174610   -23     
=======================================
- Hits       123144   123131   -13     
+ Misses      46261    46250   -11     
- Partials     5228     5229    +1     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (+<0.01%) ⬆️
db-migration 0.16% <0.00%> (+<0.01%) ⬆️
genesis-check 1.35% <0.00%> (+<0.01%) ⬆️
linux 68.92% <70.27%> (+0.02%) ⬆️
linux-nightly 70.12% <70.27%> (+0.01%) ⬆️
pytests 1.65% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.46% <0.00%> (+<0.01%) ⬆️
unittests 70.35% <70.27%> (+<0.01%) ⬆️
upgradability 0.20% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagisa nagisa added this pull request to the merge queue Jan 23, 2025
Merged via the queue into near:master with commit 2375fd7 Jan 23, 2025
26 of 28 checks passed
@nagisa nagisa deleted the stabilize-relaxed-chunk-validation branch January 23, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants