Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chain: require that new_transactions are empty #12630

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

nagisa
Copy link
Collaborator

@nagisa nagisa commented Dec 16, 2024

Based on top of #12627.

@nagisa nagisa requested a review from a team as a code owner December 16, 2024 15:37
@nagisa nagisa requested a review from wacban December 16, 2024 15:37
@akhi3030
Copy link
Collaborator

@pugachAG: are you around to help review this PR please?

@akhi3030 akhi3030 requested a review from pugachAG December 17, 2024 15:16
@nagisa nagisa force-pushed the require-empty-new-transactions branch from 5239f5f to e2833fb Compare January 14, 2025 12:34
@nagisa nagisa force-pushed the require-empty-new-transactions branch from e2833fb to f53831d Compare January 14, 2025 12:35
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.65%. Comparing base (fd4f44e) to head (f53831d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...chain/src/stateless_validation/chunk_validation.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12630       +/-   ##
===========================================
+ Coverage    1.65%   70.65%   +69.00%     
===========================================
  Files         670      848      +178     
  Lines      120798   174088    +53290     
  Branches   120798   174088    +53290     
===========================================
+ Hits         2001   123008   +121007     
+ Misses     118694    45942    -72752     
- Partials      103     5138     +5035     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (?)
db-migration 0.16% <0.00%> (ø)
genesis-check 1.35% <0.00%> (-0.01%) ⬇️
linux 69.22% <0.00%> (+67.56%) ⬆️
linux-nightly 70.23% <40.00%> (?)
pytests 1.65% <0.00%> (-0.01%) ⬇️
sanity-checks 1.46% <0.00%> (-0.01%) ⬇️
unittests 70.49% <40.00%> (?)
upgradability 0.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagisa nagisa added this pull request to the merge queue Jan 14, 2025
Merged via the queue into near:master with commit 8c0e9b9 Jan 14, 2025
28 checks passed
@nagisa nagisa deleted the require-empty-new-transactions branch January 14, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants