Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bench): add tooling for synthetic native transfer benchmarks #12570

Merged
merged 18 commits into from
Dec 12, 2024

Conversation

mooori
Copy link
Contributor

@mooori mooori commented Dec 6, 2024

Adds tooling to benchmark native token transfers with the benchmark-native-transfer command. The accounts involved in that benchmark can be generated with create-sub-accounts. Examples of how to execute both commands are given in the justfile. Documentation is available in benchmarking_synthetic_workloads.md.

The tooling is based on Rust and near-jsonrpc-client. Having the Rust toolchain installed should be sufficient to use it.

This PR is rather big. Splitting it up into smaller pieces would result in parts that don't fully support running a workload. I assume that wouldn't be favorable.

The code added here is benchmark tooling only which doesn't affect neard, so I it shouldn't be able to break anything in production.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.48%. Comparing base (4ee8111) to head (f53e7b6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12570      +/-   ##
==========================================
- Coverage   70.48%   70.48%   -0.01%     
==========================================
  Files         845      845              
  Lines      171985   171985              
  Branches   171985   171985              
==========================================
- Hits       121227   121221       -6     
- Misses      45644    45650       +6     
  Partials     5114     5114              
Flag Coverage Δ
backward-compatibility 0.16% <ø> (ø)
db-migration 0.16% <ø> (ø)
genesis-check 1.29% <ø> (ø)
linux 69.41% <ø> (+0.01%) ⬆️
linux-nightly 70.05% <ø> (-0.01%) ⬇️
pytests 1.60% <ø> (ø)
sanity-checks 1.41% <ø> (ø)
unittests 70.31% <ø> (-0.01%) ⬇️
upgradability 0.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mooori mooori requested a review from akhi3030 December 11, 2024 16:44
@mooori mooori marked this pull request as ready for review December 11, 2024 16:44
@mooori mooori requested a review from a team as a code owner December 11, 2024 16:44
Copy link
Collaborator

@akhi3030 akhi3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to merge this in and we can make improvements as needed as the benchmarking evolves or when others who are using it find ways of making improvements to it.

@mooori mooori enabled auto-merge December 12, 2024 15:22
@mooori mooori added this pull request to the merge queue Dec 12, 2024
Merged via the queue into near:master with commit 649743f Dec 12, 2024
29 checks passed
@mooori mooori deleted the bm-native-transfer branch December 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants