Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken links #10359

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix broken links #10359

merged 1 commit into from
Dec 21, 2023

Conversation

Ekleog-NEAR
Copy link
Collaborator

@Ekleog-NEAR Ekleog-NEAR commented Dec 20, 2023

This fixes the lychee check, that had started failing after #10343 landed. It also uses local links rather than remote links, which should help future breakage to be detected before the PR lands, and not after.

@Ekleog-NEAR Ekleog-NEAR added the C-housekeeping Category: Refactoring, cleanups, code quality label Dec 20, 2023
@Ekleog-NEAR Ekleog-NEAR requested a review from a team as a code owner December 20, 2023 16:55
@Ekleog-NEAR Ekleog-NEAR requested a review from nikurt December 20, 2023 16:55
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38efea2) 71.90% compared to head (c8b0d97) 71.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10359      +/-   ##
==========================================
- Coverage   71.90%   71.90%   -0.01%     
==========================================
  Files         716      716              
  Lines      143750   143750              
  Branches   143750   143750              
==========================================
- Hits       103368   103366       -2     
- Misses      35632    35638       +6     
+ Partials     4750     4746       -4     
Flag Coverage Δ
backward-compatibility 0.08% <ø> (ø)
db-migration 0.08% <ø> (ø)
genesis-check 1.25% <ø> (ø)
integration-tests 36.49% <ø> (ø)
linux 71.46% <ø> (-0.01%) ⬇️
linux-nightly 71.48% <ø> (+<0.01%) ⬆️
macos 54.78% <ø> (+1.07%) ⬆️
pytests 1.48% <ø> (ø)
sanity-checks 1.28% <ø> (ø)
unittests 68.16% <ø> (-0.01%) ⬇️
upgradability 0.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nagisa nagisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, when I was testing this locally, it failed a bunch first due to DNS resolution errors and such (I should probably review my DNS server) and then it passed fine on a repeat run 🤷

@Ekleog-NEAR Ekleog-NEAR added this pull request to the merge queue Dec 21, 2023
Merged via the queue into near:master with commit 9423f41 Dec 21, 2023
@Ekleog-NEAR Ekleog-NEAR deleted the fix-links branch December 21, 2023 13:15
@@ -1,17 +1,17 @@
# Parameter Definitions

Gas parameters are a subset of runtime parameters that are defined in
[core/primitives/res/runtime_configs/parameters.yaml](https://github.com/near/nearcore/blob/master/core/primitives/res/runtime_configs/parameters.yaml).
[runtime_configs/parameters.yaml](../../../core/parameters/res/runtime_configs/parameters.yaml).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check Hackenproof bug reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants