-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix broken links #10359
fix broken links #10359
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10359 +/- ##
==========================================
- Coverage 71.90% 71.90% -0.01%
==========================================
Files 716 716
Lines 143750 143750
Branches 143750 143750
==========================================
- Hits 103368 103366 -2
- Misses 35632 35638 +6
+ Partials 4750 4746 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, when I was testing this locally, it failed a bunch first due to DNS resolution errors and such (I should probably review my DNS server) and then it passed fine on a repeat run 🤷
@@ -1,17 +1,17 @@ | |||
# Parameter Definitions | |||
|
|||
Gas parameters are a subset of runtime parameters that are defined in | |||
[core/primitives/res/runtime_configs/parameters.yaml](https://github.com/near/nearcore/blob/master/core/primitives/res/runtime_configs/parameters.yaml). | |||
[runtime_configs/parameters.yaml](../../../core/parameters/res/runtime_configs/parameters.yaml). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check Hackenproof bug reports
This fixes the lychee check, that had started failing after #10343 landed. It also uses local links rather than remote links, which should help future breakage to be detected before the PR lands, and not after.