fix: Document HeaderSync #10280
Merged
fix: Document HeaderSync #10280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 1, 2023 15:16
It solves the problem of nodes going into header sync or body sync for just a few seconds. It's not a problem for an rpc node, but for a validator that is enough to miss production of a chunk or a block. Short syncs are not shown in prometheus due to the large poll interval.
wacban
approved these changes
Dec 1, 2023
| SyncStatus::NoSync | SyncStatus::AwaitingPeers | SyncStatus::EpochSync { .. } => { | ||
| // TODO: How can it get to EpochSync if it's hardcoded to go from NoSync to HeaderSync? |
There was a problem hiding this comment.
cc @posvyatokum I guess
some more epoch sync questions below too
Comment on lines
+166
to
+167
| // TODO: This function should check the difference between the current header_head height and the highest height of the peers. | ||
| // TODO: Triggering header sync to get 1 header (or even 0 headers) makes little sense. |
There was a problem hiding this comment.
maybe ramp up for @telezhnaya ?
| @@ -225,7 +225,7 @@ pub struct ClientConfig { | |||
| pub header_sync_progress_timeout: Duration, | |||
| /// How much time to wait before banning a peer in header sync if sync is too slow | |||
| pub header_sync_stall_ban_timeout: Duration, | |||
| /// Expected increase of header head weight per second during header sync | |||
| /// Expected increase of header head height per second during header sync | |||
added 2 commits
December 1, 2023 16:03
nikurt
force-pushed
the
nikurt-header-sync-doc
branch
from
97dc1f5 to
6299b01
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10280 +/- ##
==========================================
- Coverage 71.78% 71.78% -0.01%
==========================================
Files 712 712
Lines 142858 142878 +20
Branches 142858 142878 +20
==========================================
+ Hits 102553 102565 +12
- Misses 35594 35607 +13
+ Partials 4711 4706 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made no functional changes except:
made_enough_progress()to make the code much simpler to understand.