Skip to content

Commit

Permalink
[resharding] Revert call to clear_resharding_data (#10207)
Browse files Browse the repository at this point in the history
  • Loading branch information
Shreyan Gupta authored Nov 17, 2023
1 parent 9816a75 commit ed3dc7e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
11 changes: 6 additions & 5 deletions chain/chain/src/chain.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1003,11 +1003,12 @@ impl Chain {
*block_hash,
GCMode::Canonical(tries.clone()),
)?;
chain_store_update.clear_resharding_data(
self.runtime_adapter.as_ref(),
self.epoch_manager.as_ref(),
*block_hash,
)?;
// TODO(resharding): Call clear_resharding_data once we figure out what's wrong
// chain_store_update.clear_resharding_data(
// self.runtime_adapter.as_ref(),
// self.epoch_manager.as_ref(),
// *block_hash,
// )?;
gc_blocks_remaining -= 1;
} else {
return Err(Error::GCError(
Expand Down
2 changes: 2 additions & 0 deletions integration-tests/src/tests/client/resharding.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1059,11 +1059,13 @@ fn test_shard_layout_upgrade_gc_impl(resharding_type: ReshardingType, rng_seed:
}

#[test]
#[ignore]
fn test_shard_layout_upgrade_gc() {
test_shard_layout_upgrade_gc_impl(ReshardingType::V1, 44);
}

#[test]
#[ignore]
fn test_shard_layout_upgrade_gc_v2() {
// TODO(resharding) remove those checks once rolled out
if checked_feature!("stable", SimpleNightshadeV2, PROTOCOL_VERSION) {
Expand Down

0 comments on commit ed3dc7e

Please sign in to comment.