Skip to content

Commit

Permalink
fix(tests): Mark some tests as slower (#12615)
Browse files Browse the repository at this point in the history
When I run the tests with `--test-threads 16` these three tests often
timeout. They work with `--test-threads 1`, but then it takes forever to
run all of the tests.

Could we move them one slowness class up?
  • Loading branch information
jancionear authored Dec 16, 2024
1 parent 4fff0bb commit 6bc2df9
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion core/store/src/opener.rs
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ mod tests {
}

#[test]
fn test_checkpoint_hot_storage_and_cleanup_columns() {
fn slow_test_checkpoint_hot_storage_and_cleanup_columns() {
let (home_dir, opener) = NodeStorage::test_opener();
let node_storage = opener.open().unwrap();
let hot_store = Store { storage: node_storage.hot_storage.clone() };
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/src/tests/client/state_dump.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ use std::sync::Arc;
#[test]
/// Produce several blocks, wait for the state dump thread to notice and
/// write files to a temp dir.
fn test_state_dump() {
fn slow_test_state_dump() {
init_test_logger();

let mut genesis = Genesis::test(vec!["test0".parse().unwrap(), "test1".parse().unwrap()], 1);
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/src/tests/client/sync_state_nodes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ fn ultra_slow_test_sync_state_dump() {

#[test]
// Test that state sync behaves well when the chunks are absent at the end of the epoch.
fn slow_test_dump_epoch_missing_chunk_in_last_block() {
fn ultra_slow_test_dump_epoch_missing_chunk_in_last_block() {
heavy_test(|| {
init_test_logger();
let epoch_length = 10;
Expand Down
2 changes: 2 additions & 0 deletions nightly/expensive.txt
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@ expensive integration-tests integration_tests tests::client::sync_state_nodes::u
expensive integration-tests integration_tests tests::client::sync_state_nodes::ultra_slow_test_sync_state_nodes --features nightly
expensive integration-tests integration_tests tests::client::sync_state_nodes::ultra_slow_test_sync_state_nodes_multishard
expensive integration-tests integration_tests tests::client::sync_state_nodes::ultra_slow_test_sync_state_nodes_multishard --features nightly
expensive integration-tests integration_tests tests::client::sync_state_nodes::ultra_slow_test_dump_epoch_missing_chunk_in_last_block
expensive integration-tests integration_tests tests::client::sync_state_nodes::ultra_slow_test_dump_epoch_missing_chunk_in_last_block --features nightly

# other tests
expensive --timeout=300 near-chain near_chain tests::garbage_collection::ultra_slow_test_clear_old_data_too_many_heights
Expand Down

0 comments on commit 6bc2df9

Please sign in to comment.