toolchain: 1.73.0 -> 1.74.0 (#10188)

I think discussion is warranted on whether we want to use the lint
inheritance. The previous way was definitely quite a bit more terse, but
it was also much less composable (e.g. it was less straightforward to
exclude or include a specific crate from a specific lint)

Cargo.toml

@@ -2,7 +2,7 @@
 version = "0.0.0" # managed by cargo-workspaces, see below
 authors = ["Near Inc <[email protected]>"]
 edition = "2021"
-rust-version = "1.73.0"
+rust-version = "1.74.0"
 repository = "https://github.com/near/nearcore"
 license = "MIT OR Apache-2.0"
 
@@ -88,6 +88,18 @@ members = [
     "utils/stdx",
 ]
 
+[workspace.lints.rust]
+warnings = "deny"
+
+[workspace.lints.clippy]
+all = { level = "allow", priority = -1 }
+clone_on_copy = "deny"
+correctness = "deny"
+derivable_impls = "deny"
+redundant_clone = "deny"
+suspicious = "deny"
+len_zero = "deny"
+
 [workspace.dependencies]
 actix = "0.13.0"
 actix-cors = "0.6.1"

chain/chain-primitives/Cargo.toml

@@ -9,7 +9,8 @@ repository.workspace = true
 license.workspace = true
 publish = true
 
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+[lints]
+workspace = true
 
 [dependencies]
 chrono.workspace = true

chain/chain/Cargo.toml

@@ -5,6 +5,9 @@ authors.workspace = true
 edition.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix.workspace = true
 ansi_term.workspace = true

chain/chunks-primitives/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 license.workspace = true
 publish = true
 
+[lints]
+workspace = true
+
 [dependencies]
 near-chain-primitives.workspace = true
 near-primitives.workspace = true

chain/chunks/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix.workspace = true
 borsh.workspace = true

chain/client-primitives/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 license.workspace = true
 publish = true
 
+[lints]
+workspace = true
+
 [dependencies]
 actix.workspace = true
 ansi_term.workspace = true

chain/client/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix-rt.workspace = true
 actix.workspace = true

chain/epoch-manager/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 borsh.workspace = true
 chrono = { workspace = true, optional = true }

chain/indexer-primitives/Cargo.toml

@@ -9,7 +9,8 @@ repository.workspace = true
 license.workspace = true
 publish = true
 
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+[lints]
+workspace = true
 
 [dependencies]
 serde.workspace = true

chain/indexer/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix.workspace = true
 anyhow.workspace = true

chain/jsonrpc-adversarial-primitives/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 serde.workspace = true
 

chain/jsonrpc-primitives/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 license.workspace = true
 publish = true
 
+[lints]
+workspace = true
+
 [dependencies]
 arbitrary.workspace = true
 serde.workspace = true

chain/jsonrpc/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix-cors.workspace = true
 actix-web.workspace = true

chain/jsonrpc/client/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix-http.workspace = true
 awc.workspace = true

chain/jsonrpc/fuzz/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [package.metadata]
 cargo-fuzz = true
 

chain/jsonrpc/jsonrpc-tests/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix.workspace = true
 awc.workspace = true

chain/network/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [build-dependencies]
 anyhow.workspace = true
 protobuf-codegen.workspace = true

chain/pool/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 borsh.workspace = true
 once_cell.workspace = true

chain/rosetta-rpc/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix-cors.workspace = true
 actix-http.workspace = true

chain/telemetry/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix.workspace = true
 awc.workspace = true

core/async/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix.workspace = true
 derive-enum-from-into.workspace = true

core/chain-configs/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 license.workspace = true
 publish = true
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow.workspace = true
 bytesize.workspace = true

core/crypto/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 license.workspace = true
 publish = true
 
+[lints]
+workspace = true
+
 [dependencies]
 blake2.workspace = true
 borsh.workspace = true

core/dyn-configs/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 license.workspace = true
 publish = true
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow.workspace = true
 once_cell.workspace = true

core/o11y/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 license.workspace = true
 publish = true
 
+[lints]
+workspace = true
+
 [dependencies]
 near-crypto.workspace = true
 near-fmt.workspace = true

core/primitives-core/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 license.workspace = true
 publish = true
 
+[lints]
+workspace = true
+
 [dependencies]
 arbitrary.workspace = true
 base64.workspace = true

core/primitives/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 license.workspace = true
 publish = true
 
+[lints]
+workspace = true
+
 [dependencies]
 arbitrary.workspace = true
 base64.workspace = true

core/store/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix-rt.workspace = true
 actix.workspace = true

genesis-tools/genesis-csv-to-json/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 chrono.workspace = true
 clap.workspace = true

genesis-tools/genesis-populate/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 borsh.workspace = true
 clap.workspace = true

genesis-tools/keypair-generator/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 clap.workspace = true
 

integration-tests/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix-rt.workspace = true
 actix.workspace = true

integration-tests/src/tests/client/sync_state_nodes.rs

@@ -413,6 +413,9 @@ fn sync_empty_state() {
 
 #[test]
 #[cfg_attr(not(feature = "expensive_tests"), ignore)]
+// FIXME(#9650): locks should not be held across await points, allowed currently only because the
+// lint started triggering during a toolchain bump.
+#[allow(clippy::await_holding_lock)]
 /// Runs one node for some time, which dumps state to a temp directory.
 /// Start the second node which gets state parts from that temp directory.
 fn sync_state_dump() {

nearcore/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 actix-rt.workspace = true
 actix-web.workspace = true

neard/Cargo.toml

@@ -8,6 +8,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [[bin]]
 path = "src/main.rs"
 name = "neard"

pytest/tests/loadtest/contract/Cargo.toml

@@ -4,6 +4,9 @@ version = "0.1.0"
 authors = ["Near Inc <[email protected]>"]
 edition = "2018"
 
+[lints]
+workspace = true
+
 [workspace]
 members = []
 

runtime/near-test-contracts/Cargo.toml

@@ -9,6 +9,9 @@ repository.workspace = true
 license.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 once_cell.workspace = true
 wat.workspace = true

runtime/near-vm-runner/Cargo.toml

@@ -10,6 +10,9 @@ license.workspace = true
 categories = ["wasm"]
 publish = true
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow = { workspace = true, optional = true }
 base64.workspace = true