-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add from-genesis
subcommand
#342
Conversation
from-genesis
commandfrom-genesis
subcommand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall! I've left a few comments. I don't want to be a blocker here, so I approve it while expecting you to solve my remarks. Thanks!
@ecp88 I remember we talked about disabling buildkite jobs for all the branches except |
c412f6f
to
93b057d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know when you finished and I can start a review (disregard my current approval, please)
when is this slated to merge? I'm having trouble with the |
@kampleforth I am working on this now, you can expect it soon |
5a32102
to
e3d9630
Compare
There is no guarantee your issue is related to this pull request. Please, consider firing an issue describing the trouble you have with |
e3d9630
to
6537660
Compare
@khorolets this is ready for re-review now. I've resolved most comments, but left a couple open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
This PR adds the
from-genesis
subcommand which does the following:This does not delete the genesis file after downloading it, this job will be left to the executor.
Majority of this code has been copied from the
master-nearcore
version of storing genesis records, the obvious difference being that we now need to download the genesis file. I've commented inline where other things differ.Closes #327