feat: ledger blind signing #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj8yfo
force-pushed
the
blind_signing
branch
2 times, most recently
from
cc7265d to
099900b
Compare
dj8yfo
force-pushed
the
blind_signing
branch
from
099900b to
093543a
Compare
This was referenced Nov 21, 2023
dj8yfo
force-pushed
the
blind_signing
branch
from
ca1442c to
2cccc87
Compare
|
@dj8yfo Is there a chance to improve the error message for old Ledger App?
|
frol
requested changes
Nov 24, 2023
frol
reviewed
Nov 27, 2023
frol
approved these changes
Dec 2, 2023
Merged
13 tasks
frol
pushed a commit
that referenced
this pull request
Mar 14, 2024
- [x] check out and build old version of near-cli-rs ([revision](https://github.com/near/near-cli-rs/tree/0f484b5053f12f3baba66cda5a82252bee916913) before [blind signature pull](#259) ) - [x] near 0.7.2 - [x] test a normal tx on `app-near`: ok https://explorer.near.org/transactions/HSE5jFuKvrDYeaxEqd445PwVsahcYgXV6kZQQY5uDsj2 - [x] test a long tx on `app-near`: error ```bash `near` CLI has a new update available 0.7.2 → 0.8.1 To update `near` CLI use: near extensions self-update Error: 0: Error occurred while signing the transaction: APDUExchangeError("Unknown Ledger APDU retcode: 27024") ❯ pcalc 27024 27024 0x6990 0y110100110010000 ❯ rg 0x6990 workdir/app-near/src/constants.h 37:#define SW_BUFFER_OVERFLOW 0x6990 ``` - [x] test a long tx on `app-near-rs`: ok https://nearblocks.io/txns/5yzwbUckGSWMyYj8hbG3jJjHWLef5atkzc2fiVrf8Loy - [x] current pr near 0.8.1 - [x] test a normal tx on `app-near`: ok https://nearblocks.io/txns/5Ptbx3iGykXKQpxYBhR9YUa5BCmS6jGjyLiE7oGYGXKN - [x] test a long tx on `app-near` : error ```bash Error: 0: Error occurred while signing the transaction: APDUExchangeError("Ledger APDU retcode: 0x6990") ``` - [x] test a long tx on `app-near-rs`: ok https://nearblocks.io/txns/2duat1ripdAxtHJjuNyNT7ZNd6adADs8LGMZ6VsV9FDm - [x] test a deploy contract tx - [x] on `app-near-rs`: ok https://nearblocks.io/txns/GV6Y9TcTMhqBUoYL6M6BxkeCXXkEe8TfmLJCVx64U7ME# ```bash Unsigned transaction: signer_id: 1b11b3b31673033936ad07bddc01f9da27d974811e480fb197c799e23480a489 receiver_id: 1b11b3b31673033936ad07bddc01f9da27d974811e480fb197c799e23480a489 actions: -- deploy contract DC1KnvBEyPhBzBxCBarMgY9ZN68krg449Dk8AxARU2QN ... ``` - [x] https://nearblocks.io/address/1b11b3b31673033936ad07bddc01f9da27d974811e480fb197c799e23480a489#contract - [x] on `app-near`: error, same behaviour as long tx (12288 bytes) ```bytes 12288 ./examples/adder/res/adder.wasm ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #33
verify:
tx link exactly from flow on screens above