Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEP 584]: Cross shard bandwidth scheduler #584

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[NEP 584]: Cross shard bandwidth scheduler #584

wants to merge 8 commits into from

Conversation

jancionear
Copy link
Contributor

No description provided.

@jancionear jancionear requested a review from a team as a code owner January 13, 2025 13:49
@jancionear jancionear changed the title NEP XXX - Cross shard bandwidth scheduler NEP 584 - Cross shard bandwidth scheduler Jan 13, 2025
@jancionear jancionear changed the title NEP 584 - Cross shard bandwidth scheduler [NEP 584]: Cross shard bandwidth scheduler Jan 13, 2025
walnut-the-cat
walnut-the-cat reviewed Jan 13, 2025
View reviewed changes
neps/nep-0584.md Outdated
}
```

Additionally, the value that is the closest to `max_receipt_size` is set to to `max_receipt_size`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two 'to'?

neps/nep-0584.md Outdated
}
```

The values are calculate using a linear interpolation between `base_bandwidth` and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'calculated'?

neps/nep-0584.md
Comment on lines +372 to +378
BandwidthSchedulerParams {
base_bandwidth: 100000,
max_shard_bandwidth: 4500000,
max_receipt_size: 4194304,
max_allowance: 4500000,
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: clarify how these values are related to the fact that we are practicing the exercise with '4 shards'

@jancionear
Copy link
Contributor Author

Matej's comment about the NEP can be found here: 0ff27d1#commitcomment-151308824

@walnut-the-cat walnut-the-cat added WG-protocol Protocol Standards Work Group should be accountable A-NEP A NEAR Enhancement Proposal (NEP). S-review/needs-sme-review A NEP in the REVIEW stage is waiting for Subject Matter Expert review. labels Jan 14, 2025
@walnut-the-cat
Copy link
Contributor

walnut-the-cat commented Jan 14, 2025 •
edited
Loading

As the moderator,

I want to kickstart the review process for this NEP, as the change is part of the upcoming release.

@jancionear , please comment once you believe this proposal is ready for SME review.

@near/wg-protocol , could you help assign SMEs who can review the proposal?

From engineering perspective, we believe @shreyan-gupta and @wacban are good candidates.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walnut-the-cat walnut-the-cat walnut-the-cat left review comments

@wacban wacban Awaiting requested review from wacban

@shreyan-gupta shreyan-gupta Awaiting requested review from shreyan-gupta

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-NEP A NEAR Enhancement Proposal (NEP). S-review/needs-sme-review A NEP in the REVIEW stage is waiting for Subject Matter Expert review. WG-protocol Protocol Standards Work Group should be accountable
Projects
NEPs
Status: REVIEW
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jancionear @walnut-the-cat @matejpavlovic