Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test to registry.is_human_call #61

Merged
merged 10 commits into from
Jul 31, 2023
Merged

Add unit test to registry.is_human_call #61

merged 10 commits into from
Jul 31, 2023

Conversation

amityadav0
Copy link
Contributor

  • Add passing test
  • Add failing test

@amityadav0 amityadav0 requested a review from a team as a code owner July 27, 2023 05:06
sczembor
sczembor reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments

@amityadav0 amityadav0 requested a review from sczembor July 27, 2023 11:27
sczembor
sczembor reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few suggestions

@amityadav0 amityadav0 requested a review from sczembor July 27, 2023 11:37
@amityadav0
Copy link
Contributor Author

Updated

@amityadav0 amityadav0 requested a review from sczembor July 29, 2023 04:42
sczembor
sczembor approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@amityadav0 amityadav0 merged commit c7adfdc into master Jul 31, 2023
3 checks passed
@amityadav0 amityadav0 deleted the human-call-test branch July 31, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sczembor sczembor sczembor approved these changes

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amityadav0 @sczembor