-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate hooks #4
Conversation
amityadav0
commented
Sep 15, 2023
•
edited
Loading
edited
- Add hooks for HoM, CoA, TC
- Add tests
Co-authored-by: Robert Zaremba <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left few comments. I think we should unit test the methods that were added. If the panics are returned in the correct scenarios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- documentation should be updated about the new roles.
- need to add a unit test with a whole flow:
- normal member makes proposal
- other members vote
-
voting_body
vetos the proposal - proposal is removed, and people can't vote
Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: sczembor <[email protected]>
The idea I am thinkging about is integrate the permissions in the existing role based model. We will need to add two new variants to the In CoA, we DON'T NEED to define new ProposalKinds (eg no need for Veto, Dismiss). CoA can make a normal FunctionCall proposal to call Once the proposal succeedes, this will be sent to HoM DAO:
In the HoM, the "CoA" role can be defined as: RolePermission {
name: "CoA",
kind: RoleKind::Group(vec![coa_address]),
permissions: {"Veto", "Dissolve"}, // Need to extend Action enum by adding Veto...
vote_policy: {}, // empty set - no voting
} Note: that we use "Veto" here, not ":Veto", because this is not an acto on a proposal. So we will need new function: Note2: later we will need to add one more permission: "Dismiss" |
If we want to extend the RoleKind then we can add |
Okay, thanks for the detailed explanation, I have updated the PR with the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nearly there
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>