Integrate multichain-tools library with Ethereum example
#54
+160
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denbite
changed the title
multichain-tools library with Ethereummultichain-tools library with Ethereum example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating the multichain-tools library into the project was mostly a smooth experience, but there are a few areas that could be improved:
At the moment, Wallet Selector isn't supported, which means users have to either import the FullAccess key (an impractical and risky option for most), or manually prepare the transaction payload for signing at MPC. While the latter is feasible, having built-in support for this would greatly improve usability
The current implementation combines signature construction and broadcasting into a single
addSignatureAndBroadcastfunction. Having these as two separate functions would be more flexible, allowing users to sign multiple transactions and broadcast them all at once.The library does not assist users in structuring transaction data for contract interactions. While this isn't necessarily a core responsibility of the library, providing at least an example of how to do it would be a valuable addition.