Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eth-wallets support #21

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Conversation

Karkunow
Copy link
Contributor

This PR adds an example of the Eth-wallets integration from the Near Wallet Selector and NEP-518 support.
See the additional docs here:
https://github.com/near/wallet-selector/blob/9a9f9535ec57633b949872bb51903e7802beb3e8/packages/ethereum-wallets/README.md

Copy link

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall. Sorry for bothering you with the formatting nits.

@gagdiez Please, review as well

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, format this file with 2-spaces indentation

@Karkunow
Copy link
Contributor Author

@frol done with the formatting fixes

@gagdiez gagdiez self-requested a review September 24, 2024 07:38
@gagdiez
Copy link
Contributor

gagdiez commented Sep 24, 2024

almost there! small changes request and we can merge this @Karkunow

@gagdiez gagdiez merged commit 3223636 into near-examples:main Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants