Add USER data model architecture #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest, I am not sure what's the use case for all of this. Do you have some context on why we created this wiki in the first place? Why do we need a structure for the user etc? Everything seems overwhelming and it introduces a high complexity to the smart contracts... |
ctindogaru
commented
Apr 27, 2022
| // Default could be set with preferences, to either always allow new or always require approval | ||
| pub notaries: LookupSet<AccountId>, | ||
| // Allows user to control who & types of data allowed to be stored | ||
| pub preferences: UnorderedMap<Hash, Vec<u8>>, |
There was a problem hiding this comment.
this might be just me, but these names are not very intuitive. What attestations should represent? What attributions should represent? Why do we need notaries etc?
Maybe I'm not understanding the purpose entirely, but everything seems over-engineered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a 1:1 copy of https://github.com/near-daos/sputnik-dao-contract/wiki/%5BDRAFT%5D-USER-Data-Model-Architectures to allow easy feedback (via PR comments) on the original proposal.