Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix build script output option #650

Merged

Conversation

johannes-wolf
Copy link
Contributor

@johannes-wolf johannes-wolf commented Jul 15, 2024

Please check contribution guide first.

Description

Using the build.sh scripts -o flag did not set the zserio_extensions.{build_dir,install_dir}, which resulted in a zserio build with the extensions missing.

We switched to using the build.sh with the -o flag in zserio-cmake-helper with commit Klebert-Engineering/zserio-cmake-helper@9a446ab in favour of calling ant directly.

Type of Change

  • Bug fix
  • New feature
  • Documentation enhancement

@johannes-wolf johannes-wolf added the bug Something isn't working label Jul 15, 2024
@johannes-wolf johannes-wolf requested a review from mikir July 15, 2024 10:00
@mikir
Copy link
Contributor

mikir commented Jul 17, 2024

Thanks a lot for that! These variables was completelly missing.

Actually, this ANT_PROPS could be improved and split them up for zserio core and extension. We will do it afterwards.

@mikir mikir merged commit f6ce97c into ndsev:master Jul 17, 2024
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants