Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2024.3.1: Datasource Config #72

Merged
merged 25 commits into from
Jul 18, 2024
Merged

Version 2024.3.1: Datasource Config #72

merged 25 commits into from
Jul 18, 2024

Conversation

josephbirkner
Copy link
Contributor

@josephbirkner josephbirkner commented Jul 9, 2024 •
edited

@josephbirkner
Parse config from new flexible YAML format.
6a464cf
@josephbirkner
Small fixes to YAML processing.
4528da0
@josephbirkner
Ensure that Node 16 is used when building for manylinux.
aabe7c5
@josephbirkner
Fix ctest flag --no-tests=error.
f8a5cba
@josephbirkner
Activate tests on macOS.
bf7a893
@josephbirkner
Add logic for watching the datasources in the config file.
55867de
@josephbirkner
Small bugfixes.
e47aee2
@josephbirkner
Added config service test and essential bugfixes.
028ace9
@josephbirkner
Integrate CLI with DataSourceConfigService.
6af5489
@josephbirkner
Deprecate serve -e and -d options.
60474c2
@josephbirkner
Catch any datasource constructor exception.
10ee3bb
@josephbirkner
Additional armor for the config file watch thread.
f8863bc
@josephbirkner
Replace semaphore with atomic bool for cross-platform compatibility.
ea09ead
@josephbirkner
Fix sonar complaints.
8e2f35d
@josephbirkner
Change some message log levels to debug.
94b0205
@josephbirkner
Recreate all datasources when the config is changed.
5fc8489
@josephbirkner
Update config docs.
1b0f085
@josephbirkner josephbirkner marked this pull request as ready for review July 18, 2024 07:31
johannes-wolf
johannes-wolf reviewed Jul 18, 2024
View reviewed changes
libs/http-service/src/cli.cpp Outdated Show resolved Hide resolved
libs/http-service/src/cli.cpp Outdated Show resolved Hide resolved
test/unit/test-config.cpp Outdated Show resolved Hide resolved
libs/service/src/config.cpp Show resolved Hide resolved
johannes-wolf
johannes-wolf approved these changes Jul 18, 2024
View reviewed changes
libs/service/include/mapget/service/config.h Show resolved Hide resolved
test/unit/test-config.cpp Outdated Show resolved Hide resolved
@johannes-wolf johannes-wolf self-requested a review July 18, 2024 14:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 18, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
22 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Package Line Rate Branch Rate Health
libs.http-datasource.src 79% 42% ➖
libs.http-service.src 75% 40% ➖
libs.logging.include.mapget 71% 33% ➖
libs.model.include.mapget.model 73% 33% ➖
libs.model.src 65% 38% ➖
libs.service.include.mapget.service 50% 0% ➖
libs.service.src 78% 45% ➖
Summary 69% (2837 / 4116) 39% (2695 / 6848) ➖

Minimum allowed line rate is 50%

@josephbirkner josephbirkner merged commit 140740a into main Jul 18, 2024
14 checks passed
@josephbirkner josephbirkner deleted the datasource-config branch July 18, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannes-wolf johannes-wolf johannes-wolf approved these changes

@MisterGC MisterGC Awaiting requested review from MisterGC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josephbirkner @johannes-wolf