Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inplace refactoring of multiple files #1635

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

alex-mckenna
Copy link
Contributor

Allow multiple files to be refactored at a time, applying ideas to each relevant file. I was bitten by this the other week at work while adding some pre-commit hooks to a repository, so if it's convenient a release after approval would be appreciated 🙂

Closes #1539.

Allow multiple files to be refactored at a time, applying ideas
to each relevant file.

Closes ndmitchell#1539.
Copy link
Collaborator

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you update the README? It currently says

Because hlint's --refactor option only works when you pass a single file, ...

@alex-mckenna alex-mckenna requested a review from zliu41 February 15, 2025 11:22
Copy link
Collaborator

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The release can only be done by @ndmitchell

@zliu41 zliu41 merged commit cf89a66 into ndmitchell:master Feb 16, 2025
5 checks passed
@alex-mckenna alex-mckenna deleted the refactor-multiple-inplace branch February 18, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor flag can only be used with an individual file
2 participants