more hints about eliminating Data.Foldable.toList #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliu41
requested changes
Dec 13, 2024
|
I have updated About this:
Would it then make sense to duplicate all the hints from #1569 as well as the ones from this PR here, into versions for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially a continuation of the already merged #1569.
One thing I'm unsure about: Would these hints also catch/apply to
Data.Set.toListcalls (based on theFoldableinstance forSet)? Or would it be necessary to duplicate all these hints (the ones from the previous issue and these ones here) forData.Set.toList?