Add local address #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is on local network. This allows going outside of your local network without having to re-enter the server address each time you leave and come back. ViewController: Added "Local address" field Set address fields to URL content Tweaked layout so names don't get truncated NetUtilities: Added NetUtilites.m/h which contain some useful tools from my library IPFTestRunner: Fix so that iperf_set_test_server_hostname isn't called when hostname is nil IPFTestRunnerViewController: Added localAddressTextField field to hold local address Added local address to be saved and restored in defaults Added call to [NetUtilities getBestAddr ...] to determine which address to use, which includes some testing to make sure the address is valid. If error, return gracefully. Address that's used is set to bold while the test is underway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "Local address" field which will automatically be used if server is on local network.
This allows going outside of your local network without having to re-enter the server address
each time you leave and come back.
Note: Documentation will need to be updated to explain this change.
ViewController:
Added "Local address" field
Set address fields to URL content
Tweaked layout so names don't get truncated
NetUtilities:
Added NetUtilites.m/h which contain some useful tools from my library
IPFTestRunner:
Fix so that iperf_set_test_server_hostname isn't called when hostname is nil
IPFTestRunnerViewController:
Added localAddressTextField field to hold local address
Added local address to be saved and restored in defaults
Added call to [NetUtilities getBestAddr ...] to determine which address to use, which
includes some testing to make sure the address is valid. If error, return gracefully.
Address that's used is set to bold while the test is underway