Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/docker update #1461

Merged
merged 9 commits into from
May 8, 2024

Conversation

rossja
Copy link
Contributor

@rossja rossja commented Sep 24, 2022

Description

Restructures the way docker is handled by creating a base image that just has scoutsuite, and then separate containers for each of the different cloud types. The result is much smaller images (they're still big, but reduced size by about half of what it was).

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@rossja
Copy link
Contributor Author

rossja commented Sep 24, 2022

Forgot to mention: this change also redoes the numbering of the image to match what version of ScoutSuite is installed.
These changes are already live in the rossja/ncc-scoutsuite dockerhub repositories (still need to look at just using github container for these...)

@murarisumit
Copy link

Hi @rossja, does this PR needs any contribution or in queue to get merged ?

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0c90ab9) 20.52% compared to head (f165e94) 20.52%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1461   +/-   ##
========================================
  Coverage    20.52%   20.52%           
========================================
  Files          384      384           
  Lines        13038    13038           
========================================
  Hits          2676     2676           
  Misses       10362    10362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fernando-gallego fernando-gallego merged commit de1b62c into nccgroup:develop May 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants