Skip to content

Conversation

@knocte
Copy link
Member

@knocte knocte commented Nov 26, 2025

Reason is we found a breaking change in .NET8, so we have
decided to maintain .NET6 in the stable branch, and only
have a .NET6->.NET8 migration path in the master branch.

This commit reverts two recent commits:
* "GitHubCI: set DOTNET_ROLL_FORWARD=major for fsxc"
(f2f3c16).
* "GitHubCI,Frontend.Console: swap .net6 with .net8"
(2a55b3a).

Reason is we found a breaking change in .NET8, so we have
decided to maintain .NET6 in the stable branch, and only
have a .NET6->.NET8 migration path in the master branch.
This way it stops complaining that .NET6.0 is too old.
Ubuntu24.04 doesn't have dotnet6 packages anymore, but dotnet8.
As we don't want the stable branch to be .NET8 compatible, we
just don't test this scenario.
Same as some macOS&windows lanes already do, otherwise we get
this error saying that the oldest .NET available is 8.x:

```
You must install or update .NET to run this application.

App: /home/runner/work/geewallet/geewallet/src/GWallet.Frontend.Console/bin/Debug/net6.0/GWallet.Frontend.Console.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64)
.NET location: /usr/share/dotnet/

The following frameworks were found:
  8.0.6 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  8.0.22 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  9.0.6 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  9.0.11 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  10.0.0 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]

Learn more:
https://aka.ms/dotnet/app-launch-failed
```
This way there's much less diff noise in this PR307.
@knocte knocte force-pushed the wip/dealWithDotNet8BreakingChangesInStableBranch branch from e8794e1 to 6272a39 Compare November 26, 2025 10:23
knocte added a commit that referenced this pull request Nov 27, 2025
Now that .NETv10 (which is an LTS) has just been released, we can
already consider v6 too old (if not, use the stable branch, see [1]),
and treat v8 as the oldest version we can still support.

[1] #307
knocte added a commit that referenced this pull request Nov 27, 2025
Now that .NETv10 (which is an LTS) has just been released, we can
already consider v6 too old (if not, use the stable branch, see [1]),
and treat v8 as the oldest version we can still support.

[1] #307
knocte added a commit that referenced this pull request Nov 27, 2025
Now that .NETv10 (which is an LTS) has just been released, we can
already consider v6 too old (if not, use the stable branch, see [1]),
and treat v8 as the oldest version we can still support.

[1] #307
knocte added a commit that referenced this pull request Nov 27, 2025
Now that .NETv10 (which is an LTS) has just been released, we can
already consider v6 too old (if not, use the stable branch, see [1]),
and treat v8 as the oldest version we can still support.

[1] #307
knocte added a commit that referenced this pull request Nov 27, 2025
Now that .NETv10 (which is an LTS) has just been released, we can
already consider v6 too old (if not, use the stable branch, see [1]),
and treat v8 as the oldest version we can still support.

[1] #307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants