-
Notifications
You must be signed in to change notification settings - Fork 36
Revert migration from .NET6 to .NET8 #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
knocte
wants to merge
5
commits into
stable
Choose a base branch
from
wip/dealWithDotNet8BreakingChangesInStableBranch
base: stable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts two recent commits: * "GitHubCI: set DOTNET_ROLL_FORWARD=major for fsxc" (f2f3c16). * "GitHubCI,Frontend.Console: swap .net6 with .net8" (2a55b3a). Reason is we found a breaking change in .NET8, so we have decided to maintain .NET6 in the stable branch, and only have a .NET6->.NET8 migration path in the master branch.
This way it stops complaining that .NET6.0 is too old.
Ubuntu24.04 doesn't have dotnet6 packages anymore, but dotnet8. As we don't want the stable branch to be .NET8 compatible, we just don't test this scenario.
Same as some macOS&windows lanes already do, otherwise we get this error saying that the oldest .NET available is 8.x: ``` You must install or update .NET to run this application. App: /home/runner/work/geewallet/geewallet/src/GWallet.Frontend.Console/bin/Debug/net6.0/GWallet.Frontend.Console.dll Architecture: x64 Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64) .NET location: /usr/share/dotnet/ The following frameworks were found: 8.0.6 at [/usr/share/dotnet/shared/Microsoft.NETCore.App] 8.0.22 at [/usr/share/dotnet/shared/Microsoft.NETCore.App] 9.0.6 at [/usr/share/dotnet/shared/Microsoft.NETCore.App] 9.0.11 at [/usr/share/dotnet/shared/Microsoft.NETCore.App] 10.0.0 at [/usr/share/dotnet/shared/Microsoft.NETCore.App] Learn more: https://aka.ms/dotnet/app-launch-failed ```
This way there's much less diff noise in this PR307.
e8794e1 to
6272a39
Compare
knocte
added a commit
that referenced
this pull request
Nov 27, 2025
Now that .NETv10 (which is an LTS) has just been released, we can already consider v6 too old (if not, use the stable branch, see [1]), and treat v8 as the oldest version we can still support. [1] #307
knocte
added a commit
that referenced
this pull request
Nov 27, 2025
Now that .NETv10 (which is an LTS) has just been released, we can already consider v6 too old (if not, use the stable branch, see [1]), and treat v8 as the oldest version we can still support. [1] #307
knocte
added a commit
that referenced
this pull request
Nov 27, 2025
Now that .NETv10 (which is an LTS) has just been released, we can already consider v6 too old (if not, use the stable branch, see [1]), and treat v8 as the oldest version we can still support. [1] #307
knocte
added a commit
that referenced
this pull request
Nov 27, 2025
Now that .NETv10 (which is an LTS) has just been released, we can already consider v6 too old (if not, use the stable branch, see [1]), and treat v8 as the oldest version we can still support. [1] #307
knocte
added a commit
that referenced
this pull request
Nov 27, 2025
Now that .NETv10 (which is an LTS) has just been released, we can already consider v6 too old (if not, use the stable branch, see [1]), and treat v8 as the oldest version we can still support. [1] #307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason is we found a breaking change in .NET8, so we have
decided to maintain .NET6 in the stable branch, and only
have a .NET6->.NET8 migration path in the master branch.