Fsdk: fix build #40
Merged
Fsdk: fix build #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, the 'macOS--dotnet6-and-mono' and 'linux-*-github--dotnet-*' CI lanes started failing with this compiler error: ``` /home/runner/work/fsx/fsx/Fsdk/Process.fs(22,31): error FS0041: No overloads match for method 'Read'. Known type of argument: int ref Available overloads: - Volatile.Read(location: inref<bool>) : bool // Argument 'location' doesn't match - Volatile.Read(location: inref<byte>) : byte // Argument 'location' doesn't match - Volatile.Read(location: inref<float32>) : float32 // Argument 'location' doesn't match - Volatile.Read(location: inref<float>) : float // Argument 'location' doesn't match - Volatile.Read(location: inref<int16>) : int16 // Argument 'location' doesn't match - Volatile.Read(location: inref<int64>) : int64 // Argument 'location' doesn't match - Volatile.Read(location: inref<int>) : int // Argument 'location' doesn't match - Volatile.Read(location: inref<nativeint>) : nativeint // Argument 'location' doesn't match - Volatile.Read(location: inref<sbyte>) : sbyte // Argument 'location' doesn't match - Volatile.Read(location: inref<uint16>) : uint16 // Argument 'location' doesn't match - Volatile.Read(location: inref<uint32>) : uint32 // Argument 'location' doesn't match - Volatile.Read(location: inref<uint64>) : uint64 // Argument 'location' doesn't match - Volatile.Read(location: inref<unativeint>) : unativeint // Argument 'location' doesn't match - Volatile.Read<'T when 'T: not struct>(location: inref<'T>) : 'T // Argument 'location' doesn't match ``` Which makes me think that they are upgrading to newer .NET versions instead of being pinned... The build fix works but not sure it's correct at runtime TBH. We will see when we start using the new version of Fsdk nuget package soon...
|
Upstream bug is 16524 in dotnet/fsharp; and looking at a referenced PR from it, it looks like this PR as it is currently might not be the best fix. |
According to @vlza (nickname in F#'s discord) this should work (see previous commit to see the build fix, but non-thread-safe approach).
knocte
force-pushed
the
wip/fixVolatileBuild
branch
from
bd23c55 to
f3b6785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, the
macOS--dotnet6-and-monoandlinux-*-github--dotnet-*CI lanes started failing with this compiler error:Which makes me think that they are upgrading to newer .NET versions instead of being pinned...
The build fix works but not sure it's correct at runtime TBH. We will see when we start using the new version of Fsdk nuget package soon...