nblockchain · webwarrior-ws · Aug 1, 2023 · Aug 1, 2023 · Aug 1, 2023 · Aug 3, 2023
diff --git a/scripts/checkCommits1by1.fsx b/scripts/checkCommits1by1.fsx
@@ -10,7 +10,7 @@ open System.Net.Http.Headers
 #r "nuget: FSharp.Data, Version=5.0.2"
 open FSharp.Data
 
-#r "nuget: Fsdk, Version=0.6.0--date20230214-0422.git-1ea6f62"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
 open Fsdk
 open Fsdk.Process

diff --git a/scripts/compileFSharpScripts.fsx b/scripts/compileFSharpScripts.fsx
@@ -3,7 +3,7 @@
 open System
 open System.IO
 
-#r "nuget: Fsdk, Version=0.6.0--date20230214-0422.git-1ea6f62"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 #load "../src/FileConventions/Helpers.fs"
 
 Fsdk

diff --git a/scripts/dotnetFileConventions.fsx b/scripts/dotnetFileConventions.fsx
@@ -0,0 +1,80 @@
+#!/usr/bin/env -S dotnet fsi
+
+open System
+open System.IO
+open System.Text.RegularExpressions
+
+#r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
+#r "nuget: YamlDotNet, Version=16.1.3"
+
+open Fsdk
+open Fsdk.Process
+
+#load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
+
+open FileConventions
+open Helpers
+
+let args = Misc.FsxOnlyArguments()
+
+if args.Length > 1 then
+    Console.Error.WriteLine
+        "Usage: dotnetFileConventions.fsx [projectFolder(optional)]"
+
+    Environment.Exit 1
+
+let rootDir = DirectoryInfo args.[0]
+
+// DefiningEmptyStringsWithDoubleQuotes
+let allSourceFiles = ReturnAllProjectSourceFiles rootDir [ "*.cs"; "*.fs" ] true
+printfn "%A" (String.Join("\n", allSourceFiles))
+
+let allProjFiles =
+    ReturnAllProjectSourceFiles rootDir [ "*.csproj"; "*.fsproj" ] true
+
+for sourceFile in allSourceFiles do
+    let isStringEmpty = DefiningEmptyStringsWithDoubleQuotes sourceFile
+
+    if isStringEmpty then
+        failwith(
+            sprintf
+                "%s file: Contains empty strings specifed with \"\" , you should use String.Empty()"
+                sourceFile.FullName
+        )
+
+
+// ProjFilesNamingConvention
+
+for projfile in allProjFiles do
+    let isWrongProjFile = ProjFilesNamingConvention projfile
+
+    if isWrongProjFile then
+        failwith(
+            sprintf
+                "%s file: Project file or Project directory is incorrect!\n
+        Fix: use same name on .csproj/.fsproj on parrent project directory"
+                projfile.FullName
+        )
+
+// notfollowingnamespaceconvention
+for sourcefile in allSourceFiles do
+    let iswrongnamespace = NotFollowingNamespaceConvention sourcefile
+
+    if iswrongnamespace then
+        failwith(sprintf "%s file: has wrong namespace!" sourcefile.FullName)
+
+// NotFollowingConsoleAppConvention
+for projfile in allProjFiles do
+    let isWrongConsoleApplication =
+        NotFollowingConsoleAppConvention projfile true
+
+    printfn "%A" projfile
+
+    if isWrongConsoleApplication then
+        failwith(
+            sprintf
+                "%s project: Should not contain console methods or printf"
+                projfile.FullName
+        )
diff --git a/scripts/eofConvention.fsx b/scripts/eofConvention.fsx
@@ -5,6 +5,7 @@ open System
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
 #load "../src/FileConventions/Helpers.fs"
 #load "../src/FileConventions/Library.fs"

diff --git a/scripts/executableConvention.fsx b/scripts/executableConvention.fsx
@@ -5,8 +5,9 @@ open System.IO
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
-#load "../src/FileConventions/Library.fs"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 #load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
 
 let rootDir = Path.Combine(__SOURCE_DIRECTORY__, "..") |> DirectoryInfo
 let currentDir = Directory.GetCurrentDirectory() |> DirectoryInfo

diff --git a/scripts/gitPush1by1.fsx b/scripts/gitPush1by1.fsx
@@ -8,7 +8,7 @@ open System.Threading
 #r "System.Configuration"
 open System.Configuration
 
-#r "nuget: Fsdk, Version=0.6.0--date20230214-0422.git-1ea6f62"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
 open Fsdk
 open Fsdk.Process

diff --git a/scripts/inconsistentNugetVersionsInDotNetProjects.fsx b/scripts/inconsistentNugetVersionsInDotNetProjects.fsx
@@ -6,7 +6,7 @@ open System.IO
 #r "System.Core.dll"
 #r "System.Xml.Linq.dll"
 
-#r "nuget: Fsdk, Version=0.6.0--date20230214-0422.git-1ea6f62"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
 open Fsdk
 

diff --git a/scripts/inconsistentNugetVersionsInDotNetProjectsAndFSharpScripts.fsx b/scripts/inconsistentNugetVersionsInDotNetProjectsAndFSharpScripts.fsx
@@ -5,13 +5,13 @@ open System.IO
 #r "System.Core.dll"
 #r "System.Xml.Linq.dll"
 
-#r "nuget: Fsdk, Version=0.6.0--date20230214-0422.git-1ea6f62"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 #r "nuget: Microsoft.Build, Version=16.11.0"
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
 
-#load "../src/FileConventions/Library.fs"
 #load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
 #load "../src/FileConventions/NugetVersionsCheck.fs"
 #load "../src/FileConventions/CombinedVersionCheck.fs"
 

diff --git a/scripts/inconsistentNugetVersionsInFSharpScripts.fsx b/scripts/inconsistentNugetVersionsInFSharpScripts.fsx
@@ -5,9 +5,10 @@ open System.Linq
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
-#load "../src/FileConventions/Library.fs"
 #load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
 
 let rootDir = Path.Combine(__SOURCE_DIRECTORY__, "..") |> DirectoryInfo
 let currentDir = Directory.GetCurrentDirectory() |> DirectoryInfo

diff --git a/scripts/inconsistentVersionsInGitHubCI.fsx b/scripts/inconsistentVersionsInGitHubCI.fsx
@@ -4,9 +4,10 @@ open System.IO
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
-#load "../src/FileConventions/Library.fs"
 #load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
 
 let rootDir = Path.Combine(__SOURCE_DIRECTORY__, "..") |> DirectoryInfo
 

diff --git a/scripts/mixedLineEndings.fsx b/scripts/mixedLineEndings.fsx
@@ -5,9 +5,10 @@ open System.IO
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
-#load "../src/FileConventions/Library.fs"
 #load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
 
 let rootDir = Path.Combine(__SOURCE_DIRECTORY__, "..") |> DirectoryInfo
 

diff --git a/scripts/nonVerboseFlagsInGitHubCIAndScripts.fsx b/scripts/nonVerboseFlagsInGitHubCIAndScripts.fsx
@@ -5,9 +5,10 @@ open System.IO
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
-#load "../src/FileConventions/Library.fs"
 #load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
 
 let rootDir = Path.Combine(__SOURCE_DIRECTORY__, "..") |> DirectoryInfo
 

diff --git a/scripts/shebangConvention.fsx b/scripts/shebangConvention.fsx
@@ -5,9 +5,10 @@ open System.IO
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
-#load "../src/FileConventions/Library.fs"
 #load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
 
 let rootDir = Path.Combine(__SOURCE_DIRECTORY__, "..") |> DirectoryInfo
 

diff --git a/scripts/unpinnedDotnetToolInstallVersions.fsx b/scripts/unpinnedDotnetToolInstallVersions.fsx
@@ -5,9 +5,10 @@ open System.IO
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
-#load "../src/FileConventions/Library.fs"
 #load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
 
 let rootDir = Path.Combine(__SOURCE_DIRECTORY__, "..") |> DirectoryInfo
 

diff --git a/scripts/unpinnedGitHubActionsImageVersions.fsx b/scripts/unpinnedGitHubActionsImageVersions.fsx
@@ -5,9 +5,10 @@ open System.IO
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
-#load "../src/FileConventions/Library.fs"
 #load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
 
 let rootDir = Path.Combine(__SOURCE_DIRECTORY__, "..") |> DirectoryInfo
 

diff --git a/scripts/unpinnedNugetPackageReferenceVersionsInFSharpScripts.fsx b/scripts/unpinnedNugetPackageReferenceVersionsInFSharpScripts.fsx
@@ -5,9 +5,10 @@ open System.IO
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
-#load "../src/FileConventions/Library.fs"
 #load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
 
 let rootDir = Path.Combine(__SOURCE_DIRECTORY__, "..") |> DirectoryInfo
 

diff --git a/scripts/unpinnedNugetPackageReferenceVersionsInProjects.fsx b/scripts/unpinnedNugetPackageReferenceVersionsInProjects.fsx
@@ -5,9 +5,10 @@ open System.IO
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
-#load "../src/FileConventions/Library.fs"
 #load "../src/FileConventions/Helpers.fs"
+#load "../src/FileConventions/Library.fs"
 
 let rootDir = Path.Combine(__SOURCE_DIRECTORY__, "..") |> DirectoryInfo
 let currentDir = Directory.GetCurrentDirectory() |> DirectoryInfo

diff --git a/scripts/wrapLatestCommitMsg.fsx b/scripts/wrapLatestCommitMsg.fsx
@@ -7,11 +7,11 @@ open System.Linq
 
 #r "nuget: Mono.Unix, Version=7.1.0-final.1.21458.1"
 #r "nuget: YamlDotNet, Version=16.1.3"
+#r "nuget: Fsdk, Version=0.6.0--date20230821-0702.git-5488853"
 
+#load "../src/FileConventions/Helpers.fs"
 #load "../src/FileConventions/Library.fs"
 
-#r "nuget: Fsdk, Version=0.6.0--date20230214-0422.git-1ea6f62"
-
 open Fsdk
 open Fsdk.Process
 

diff --git a/.../DummyConsoleProjectWithRightName.Console/DummyConsoleProjectWithRightName.Console.fsproj b/.../DummyConsoleProjectWithRightName.Console/DummyConsoleProjectWithRightName.Console.fsproj
@@ -0,0 +1,12 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net7.0</TargetFramework>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <Compile Include="Program.fs" />
+  </ItemGroup>
+
+</Project>
diff --git a/src/FileConventions.Test/DummyFiles/DummyConsoleProjectWithRightName.Console/Program.fs b/src/FileConventions.Test/DummyFiles/DummyConsoleProjectWithRightName.Console/Program.fs
@@ -0,0 +1 @@
+printf "Hello World"
diff --git a/....Test/DummyFiles/DummyConsoleProjectWithWrongName/DummyConsoleProjectWithWrongName.fsproj b/....Test/DummyFiles/DummyConsoleProjectWithWrongName/DummyConsoleProjectWithWrongName.fsproj
@@ -0,0 +1,12 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net7.0</TargetFramework>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <Compile Include="Program.fs" />
+  </ItemGroup>
+
+</Project>
diff --git a/src/FileConventions.Test/DummyFiles/DummyConsoleProjectWithWrongName/Program.fs b/src/FileConventions.Test/DummyFiles/DummyConsoleProjectWithWrongName/Program.fs
@@ -0,0 +1 @@
+printf "Hello World"
diff --git a/...FileWithTheSameNameAsItsParentFolder/DummyProjFileWithTheSameNameAsItsParentFolder.fsproj b/...FileWithTheSameNameAsItsParentFolder/DummyProjFileWithTheSameNameAsItsParentFolder.fsproj
diff --git a/...ions.Test/DummyFiles/DummyProject/DummyProjFileWithoutTheSameNameAsItsParentFolder.fsproj b/...ions.Test/DummyFiles/DummyProject/DummyProjFileWithoutTheSameNameAsItsParentFolder.fsproj
diff --git a/...ileConventions.Test/DummyFiles/DummyProjectAsync.Console/DummyProjectAsync.Console.fsproj b/...ileConventions.Test/DummyFiles/DummyProjectAsync.Console/DummyProjectAsync.Console.fsproj
@@ -0,0 +1,12 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net7.0</TargetFramework>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <Compile Include="Program.fs" />
+  </ItemGroup>
+
+</Project>
diff --git a/src/FileConventions.Test/DummyFiles/DummyProjectAsync.Console/Program.fs b/src/FileConventions.Test/DummyFiles/DummyProjectAsync.Console/Program.fs
@@ -0,0 +1,2 @@
+async { do! Async.Sleep(5000) } |> Async.RunSynchronously
+printf "Hello World"
diff --git a/src/FileConventions.Test/DummyFiles/DummyProjectAsync/DummyProjectAsync.fsproj b/src/FileConventions.Test/DummyFiles/DummyProjectAsync/DummyProjectAsync.fsproj
@@ -0,0 +1,12 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net7.0</TargetFramework>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <Compile Include="Library.fs" />
+  </ItemGroup>
+
+</Project>
diff --git a/src/FileConventions.Test/DummyFiles/DummyProjectAsync/Library.fs b/src/FileConventions.Test/DummyFiles/DummyProjectAsync/Library.fs
@@ -0,0 +1,7 @@
+namespace DummyProjectAsync
+
+module Say =
+
+    let delayedHello name =
+        async { do! Async.Sleep(5000) } |> Async.RunSynchronously
+        "Delayed Hello"
diff --git a/...ntions.Test/DummyFiles/DummyProjectWithRight.Console/DummyProjectWithRight.Console.fsproj b/...ntions.Test/DummyFiles/DummyProjectWithRight.Console/DummyProjectWithRight.Console.fsproj
@@ -0,0 +1,12 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net7.0</TargetFramework>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <Compile Include="Program.fs" />
+  </ItemGroup>
+
+</Project>
diff --git a/src/FileConventions.Test/DummyFiles/DummyProjectWithRight.Console/Program.fs b/src/FileConventions.Test/DummyFiles/DummyProjectWithRight.Console/Program.fs
@@ -0,0 +1 @@
+printf "Hello World"
diff --git a/...ventions.Test/DummyFiles/DummyProjectWithWrongConsole/DummyProjectWithWrongConsole.fsproj b/...ventions.Test/DummyFiles/DummyProjectWithWrongConsole/DummyProjectWithWrongConsole.fsproj
@@ -0,0 +1,12 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net7.0</TargetFramework>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <Compile Include="Library.fs" />
+  </ItemGroup>
+
+</Project>
diff --git a/src/FileConventions.Test/DummyFiles/DummyProjectWithWrongConsole/Library.fs b/src/FileConventions.Test/DummyFiles/DummyProjectWithWrongConsole/Library.fs
@@ -0,0 +1,6 @@
+// printf not accepted here
+namespace DummyProjectWithWrongConsole
+
+module Say =
+    let hello name =
+        printfn "Hello %s" name
diff --git a/src/FileConventions.Test/DummyFiles/DummyScriptWithConventionalEmptyString.fsx b/src/FileConventions.Test/DummyFiles/DummyScriptWithConventionalEmptyString.fsx
@@ -0,0 +1,6 @@
+#!/usr/bin/env -S dotnet fsi
+
+open System
+open System.IO
+
+let emptyString = String.Empty
diff --git a/src/FileConventions.Test/DummyFiles/DummyScriptWithEmptyString.fsx b/src/FileConventions.Test/DummyFiles/DummyScriptWithEmptyString.fsx
@@ -0,0 +1 @@
+let myString = "\"Hello World\""
diff --git a/src/FileConventions.Test/DummyFiles/DummyScriptWithMatchEmptyString.fsx b/src/FileConventions.Test/DummyFiles/DummyScriptWithMatchEmptyString.fsx
@@ -0,0 +1,5 @@
+let temp = "Hello World"
+
+match temp with
+| "" -> failwith "Empty String"
+| _ -> failwith "Non-Empty String"
diff --git a/src/FileConventions.Test/DummyFiles/DummyScriptWithNonConventionalEmptyString.fsx b/src/FileConventions.Test/DummyFiles/DummyScriptWithNonConventionalEmptyString.fsx
@@ -0,0 +1,6 @@
+#!/usr/bin/env -S dotnet fsi
+
+open System
+open System.IO
+
+let emptyString = ""
diff --git a/src/FileConventions.Test/DummyFiles/src/Foo/Bar/DummyFileUnderBarWithRightNamespace.fs b/src/FileConventions.Test/DummyFiles/src/Foo/Bar/DummyFileUnderBarWithRightNamespace.fs
@@ -0,0 +1 @@
+namespace Foo.Bar
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		async { do! Async.Sleep(5000) } \|> Async.RunSynchronously
		printf "Hello World"