Skip to content

commitlint/fpHelpers: NonNullable in IsInstanceOf #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

commitlint/fpHelpers: NonNullable in IsInstanceOf #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5508fc
commitlint/fpHelpers: NonNullable in IsInstanceOf
knocte Sep 11, 2024
0b58248
docs: removes unnecessary else block from snippet
knocte Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion commitlint/fpHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ export class TypeHelpers {
}

// because instanceof doesn't work with primitive types (e.g. String), taken from https://stackoverflow.com/a/58184883/544947
public static IsInstanceOf(variable: any, type: any) {
public static IsInstanceOf(
variable: NonNullable<any>,
type: NonNullable<any>
) {
if (TypeHelpers.IsNullOrUndefined(variable)) {
throw new Error(
"Invalid 'variable' parameter passed in: null or undefined"
Expand Down
5 changes: 1 addition & 4 deletions docs/WorkflowGuidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,7 @@
{
return 0;
}
else
{
return 1;
}
return 1;
```

Improved code:
Expand Down