Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requestedAuthnContextComparison to security configuration #58

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

nexxome
Copy link
Contributor

@nexxome nexxome commented Aug 28, 2024

This PR added requestedAuthnContextComparison to security configuration:

    // Allows the authn comparison parameter to be set, defaults to 'exact' if 
    // the setting is not present.
    'requestedAuthnContextComparison' => 'exact',

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (8f6d83f) to head (fd59708).
Report is 2 commits behind head on 2.0.

Additional details and impacted files
Files with missing lines Coverage Δ
src/DependencyInjection/Configuration.php 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f6d83f...fd59708. Read the comment docs.

@a-menshchikov
Copy link
Contributor

@nexxome thank you for your contribution.
Could you rebase this PR to the 1.4 branch? After merge I will spread it into the 2.0.

@a-menshchikov a-menshchikov merged commit d2feeb7 into nbgrp:2.0 Sep 1, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants